Re: [PATCH] rmap: Fix compound check logic in page_remove_file_rmap

2016-08-09 Thread Kirill A. Shutemov
On Tue, Aug 09, 2016 at 01:34:35PM +0100, Steve Capper wrote: > In page_remove_file_rmap(.) we have the following check: > VM_BUG_ON_PAGE(compound && !PageTransHuge(page), page); > > This is meant to check for either HugeTLB pages or THP when a compound > page is passed in. > > Unfortunately,

Re: [PATCH] rmap: Fix compound check logic in page_remove_file_rmap

2016-08-09 Thread Kirill A. Shutemov
On Tue, Aug 09, 2016 at 01:34:35PM +0100, Steve Capper wrote: > In page_remove_file_rmap(.) we have the following check: > VM_BUG_ON_PAGE(compound && !PageTransHuge(page), page); > > This is meant to check for either HugeTLB pages or THP when a compound > page is passed in. > > Unfortunately,

[PATCH] rmap: Fix compound check logic in page_remove_file_rmap

2016-08-09 Thread Steve Capper
In page_remove_file_rmap(.) we have the following check: VM_BUG_ON_PAGE(compound && !PageTransHuge(page), page); This is meant to check for either HugeTLB pages or THP when a compound page is passed in. Unfortunately, if one disables CONFIG_TRANSPARENT_HUGEPAGE, then PageTransHuge(.) will

[PATCH] rmap: Fix compound check logic in page_remove_file_rmap

2016-08-09 Thread Steve Capper
In page_remove_file_rmap(.) we have the following check: VM_BUG_ON_PAGE(compound && !PageTransHuge(page), page); This is meant to check for either HugeTLB pages or THP when a compound page is passed in. Unfortunately, if one disables CONFIG_TRANSPARENT_HUGEPAGE, then PageTransHuge(.) will