Re: [PATCH] rpmsg: rpmsg_core: fix null-ptr dereference for devices without ops

2017-06-28 Thread Bjorn Andersson
On Mon 26 Jun 02:04 PDT 2017, Henri Roosen wrote: > On 06/25/2017 11:51 PM, Bjorn Andersson wrote: > > On Fri 02 Jun 04:35 PDT 2017, Henri Roosen wrote: > > > > > A device might not have an ops structure registered. This > > > patch fixes a null-prt dereference by checking ops before dereferencin

Re: [PATCH] rpmsg: rpmsg_core: fix null-ptr dereference for devices without ops

2017-06-26 Thread Henri Roosen
On 06/25/2017 11:51 PM, Bjorn Andersson wrote: On Fri 02 Jun 04:35 PDT 2017, Henri Roosen wrote: A device might not have an ops structure registered. This patch fixes a null-prt dereference by checking ops before dereferencing it. In what scenario do you end up with a rpdev without ops defin

Re: [PATCH] rpmsg: rpmsg_core: fix null-ptr dereference for devices without ops

2017-06-25 Thread Bjorn Andersson
On Fri 02 Jun 04:35 PDT 2017, Henri Roosen wrote: > A device might not have an ops structure registered. This > patch fixes a null-prt dereference by checking ops before dereferencing > it. > In what scenario do you end up with a rpdev without ops defined? You need at least create_ept defined i

Re: [PATCH] rpmsg: rpmsg_core: fix null-ptr dereference for devices without ops

2017-06-02 Thread Suman Anna
Hi Henri, On 06/02/2017 06:35 AM, Henri Roosen wrote: > A device might not have an ops structure registered. This The rpmsg devices are registered from the respective backends, which are supposed to plug in their ops. What is the scenario where you think these ops might not be populated? We ought

[PATCH] rpmsg: rpmsg_core: fix null-ptr dereference for devices without ops

2017-06-02 Thread Henri Roosen
A device might not have an ops structure registered. This patch fixes a null-prt dereference by checking ops before dereferencing it. Signed-off-by: Henri Roosen --- drivers/rpmsg/rpmsg_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rpmsg/rpmsg_core.c b/driver