Re: [PATCH] rsi: Properly initialize data in rsi_sdio_ta_reset

2019-05-23 Thread Kalle Valo
Arnd Bergmann writes: >> > @@ -937,7 +937,7 @@ static int rsi_sdio_ta_reset(struct rsi_hw *adapter) >> > } >> > >> > rsi_dbg(INIT_ZONE, "%s: Bring TA out of reset\n", __func__); >> > - put_unaligned_le32(TA_HOLD_THREAD_VALUE, data); >> > + put_unaligned_le32(TA_HOLD_TH

Re: [PATCH] rsi: Properly initialize data in rsi_sdio_ta_reset

2019-05-23 Thread Kalle Valo
Nathan Chancellor writes: > On Thu, May 02, 2019 at 08:17:18PM -0700, Nathan Chancellor wrote: >> On Thu, May 02, 2019 at 11:18:01AM -0700, Nick Desaulniers wrote: >> > On Thu, May 2, 2019 at 8:16 AM Nathan Chancellor >> > wrote: >> > > >> > > When building with -Wuninitialized, Clang warns: >>

Re: [PATCH] rsi: Properly initialize data in rsi_sdio_ta_reset

2019-05-23 Thread Arnd Bergmann
On Thu, May 23, 2019 at 3:54 AM Nathan Chancellor wrote: > > On Thu, May 02, 2019 at 08:17:18PM -0700, Nathan Chancellor wrote: > > On Thu, May 02, 2019 at 11:18:01AM -0700, Nick Desaulniers wrote: > > > On Thu, May 2, 2019 at 8:16 AM Nathan Chancellor > > > u8 data [4]; > > > > data was __le32 in

Re: [PATCH] rsi: Properly initialize data in rsi_sdio_ta_reset

2019-05-22 Thread Nathan Chancellor
On Thu, May 02, 2019 at 08:17:18PM -0700, Nathan Chancellor wrote: > On Thu, May 02, 2019 at 11:18:01AM -0700, Nick Desaulniers wrote: > > On Thu, May 2, 2019 at 8:16 AM Nathan Chancellor > > wrote: > > > > > > When building with -Wuninitialized, Clang warns: > > > > > > drivers/net/wireless/rsi/r