Re: [PATCH] rsi: fix potential null dereference in rsi_probe()

Johan Hovold writes: > On Fri, Oct 04, 2019 at 01:47:36PM +, Kalle Valo wrote: >> Denis Efremov wrote: >> >> > The id pointer can be NULL in rsi_probe(). > > While the existing code in rsi_probe() may lead you to believe that, > this statement is false. > >> > It is checked everywhere exce

Re: [PATCH] rsi: fix potential null dereference in rsi_probe()

On Fri, Oct 04, 2019 at 01:47:36PM +, Kalle Valo wrote: > Denis Efremov wrote: > > > The id pointer can be NULL in rsi_probe(). While the existing code in rsi_probe() may lead you to believe that, this statement is false. > > It is checked everywhere except > > for the else branch in the i

Re: [PATCH] rsi: fix potential null dereference in rsi_probe()

Denis Efremov wrote: > The id pointer can be NULL in rsi_probe(). It is checked everywhere except > for the else branch in the idProduct condition. The patch adds NULL check > before the id dereference in the rsi_dbg() call. > > Fixes: 54fdb318c111 ("rsi: add new device model for 9116") > Cc: Am

[PATCH] rsi: fix potential null dereference in rsi_probe()

The id pointer can be NULL in rsi_probe(). It is checked everywhere except for the else branch in the idProduct condition. The patch adds NULL check before the id dereference in the rsi_dbg() call. Fixes: 54fdb318c111 ("rsi: add new device model for 9116") Cc: Amitkumar Karwar Cc: Siva Rebbagondl