Re: [PATCH] rt_mutex: correctly initialize lockdep in rt_mutex_init_proxy_locked

2017-06-12 Thread Peter Zijlstra
On Sun, Jun 11, 2017 at 02:51:09PM +, Levin, Alexander (Sasha Levin) wrote: > On Sat, Jun 10, 2017 at 04:02:12PM +0200, Peter Zijlstra wrote: > > On Sat, Jun 10, 2017 at 02:48:04AM +, Levin, Alexander (Sasha Levin) > > wrote: > > > lockdep can't deal with NULL name or key, and doesn't do

Re: [PATCH] rt_mutex: correctly initialize lockdep in rt_mutex_init_proxy_locked

2017-06-12 Thread Peter Zijlstra
On Sun, Jun 11, 2017 at 02:51:09PM +, Levin, Alexander (Sasha Levin) wrote: > On Sat, Jun 10, 2017 at 04:02:12PM +0200, Peter Zijlstra wrote: > > On Sat, Jun 10, 2017 at 02:48:04AM +, Levin, Alexander (Sasha Levin) > > wrote: > > > lockdep can't deal with NULL name or key, and doesn't do

Re: [PATCH] rt_mutex: correctly initialize lockdep in rt_mutex_init_proxy_locked

2017-06-11 Thread Levin, Alexander (Sasha Levin)
On Sat, Jun 10, 2017 at 04:02:12PM +0200, Peter Zijlstra wrote: > On Sat, Jun 10, 2017 at 02:48:04AM +, Levin, Alexander (Sasha Levin) > wrote: > > lockdep can't deal with NULL name or key, and doesn't do anything > > with the lock when that happens. > > Not doing anything is 'right', the

Re: [PATCH] rt_mutex: correctly initialize lockdep in rt_mutex_init_proxy_locked

2017-06-11 Thread Levin, Alexander (Sasha Levin)
On Sat, Jun 10, 2017 at 04:02:12PM +0200, Peter Zijlstra wrote: > On Sat, Jun 10, 2017 at 02:48:04AM +, Levin, Alexander (Sasha Levin) > wrote: > > lockdep can't deal with NULL name or key, and doesn't do anything > > with the lock when that happens. > > Not doing anything is 'right', the

Re: [PATCH] rt_mutex: correctly initialize lockdep in rt_mutex_init_proxy_locked

2017-06-10 Thread Peter Zijlstra
On Sat, Jun 10, 2017 at 02:48:04AM +, Levin, Alexander (Sasha Levin) wrote: > lockdep can't deal with NULL name or key, and doesn't do anything > with the lock when that happens. Not doing anything is 'right', the proxy stuff won't be lockdep tracked anyway. But yeah, the first thing is a wee

Re: [PATCH] rt_mutex: correctly initialize lockdep in rt_mutex_init_proxy_locked

2017-06-10 Thread Peter Zijlstra
On Sat, Jun 10, 2017 at 02:48:04AM +, Levin, Alexander (Sasha Levin) wrote: > lockdep can't deal with NULL name or key, and doesn't do anything > with the lock when that happens. Not doing anything is 'right', the proxy stuff won't be lockdep tracked anyway. But yeah, the first thing is a wee

[PATCH] rt_mutex: correctly initialize lockdep in rt_mutex_init_proxy_locked

2017-06-09 Thread Levin, Alexander (Sasha Levin)
lockdep can't deal with NULL name or key, and doesn't do anything with the lock when that happens. Make rt_mutex_init_proxy_locked pass a name and a key for the lock. Fixes: f5694788ad8d ("rt_mutex: Add lockdep annotations") Cc: Linus Torvalds Cc: Peter Zijlstra

[PATCH] rt_mutex: correctly initialize lockdep in rt_mutex_init_proxy_locked

2017-06-09 Thread Levin, Alexander (Sasha Levin)
lockdep can't deal with NULL name or key, and doesn't do anything with the lock when that happens. Make rt_mutex_init_proxy_locked pass a name and a key for the lock. Fixes: f5694788ad8d ("rt_mutex: Add lockdep annotations") Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Ingo