On Sun, 19 Aug 2007 19:02:04 -0700, David Brownell <[EMAIL PROTECTED]> wrote:
> This is indeed a platform driver. And v2 of this patch
> doesn't resolve its "won't hotplug" problem. The simplest
> way to resolve that would be switching to the more widely
> used platform_device_register().
Yes, i
On Sunday 19 August 2007, David Brownell wrote:
> On Sunday 19 August 2007, Kay Sievers wrote:
> > No, I object to the concept of "platform" to disable all uevents by
> > default,
>
> Which it certainly doesn't do.
>
> Since the $SUBJECT patch doesn't affect a platform driver in any case,
> all t
On Sunday 19 August 2007, Kay Sievers wrote:
> No, I object to the concept of "platform" to disable all uevents by
> default,
Which it certainly doesn't do.
Since the $SUBJECT patch doesn't affect a platform driver in any case,
all those comments are well off-topic for $SUBJECT.
-
To unsubscribe
On Sun, 2007-08-19 at 21:57 +0900, Atsushi Nemoto wrote:
> On Fri, 17 Aug 2007 18:32:19 +0200, "Kay Sievers" <[EMAIL PROTECTED]> wrote:
> > > I guess there are some out-of-tree users of this driver, but fixing
> > > them is really trivial, so I don't think this is a big compatibility
> > > problem.
The rtc-ds1742 platform driver name doesn't match its module name,
which might prevents it from properly hotplugging. There is only two
in-tree user of its driver, which are fixed by this patch too.
Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]>
---
arch/mips/jmr3927/rbhma3100/setup.c
On Fri, 17 Aug 2007 18:32:19 +0200, "Kay Sievers" <[EMAIL PROTECTED]> wrote:
> > I guess there are some out-of-tree users of this driver, but fixing
> > them is really trivial, so I don't think this is a big compatibility
> > problem.
>
> Again, the only sane solution is to provide MODALIAS="platf
On Fri, 2007-08-17 at 21:06 -0700, David Brownell wrote:
> On Friday 17 August 2007, Kay Sievers wrote:
> >
> > > I'm not the one who's advocating a change here. If you want to
> > > first change/break and then fix things, all of that is up to you.
> >
> > I'm happy to do that. Patch is attached
On Friday 17 August 2007, Kay Sievers wrote:
>
> > I'm not the one who's advocating a change here. If you want to
> > first change/break and then fix things, all of that is up to you.
>
> I'm happy to do that. Patch is attached.
NAK. That wasn't even a serious attempt at the "fix" part,
though
On Fri, 2007-08-17 at 12:50 -0700, David Brownell wrote:
> On Friday 17 August 2007, Kay Sievers wrote:
> > On Fri, 2007-08-17 at 09:55 -0700, David Brownell wrote:
> > >
> > > If so, then whoever tried to change the usage of module aliases
> > > in that way goofed in several ways. First, by not
On Friday 17 August 2007, Jan Engelhardt wrote:
> >> We exchanges several mails a few weeks ago after the Debian bug caused
> >> by a modprobe loop.
> >
> >Which has been fixed for some time now; it was caused by legacy
> >drivers, which are incapable of hotplugging.
>
> Speaking of which ... doe
On Aug 17 2007 12:50, David Brownell wrote:
>On Friday 17 August 2007, Kay Sievers wrote:
>> On Fri, 2007-08-17 at 09:55 -0700, David Brownell wrote:
>> > On Friday 17 August 2007, Kay Sievers wrote:
>> > > Again,
>> >
>> > "Again"?
>>
>> We exchanges several mails a few weeks ago after the Debi
On Friday 17 August 2007, Kay Sievers wrote:
> On Fri, 2007-08-17 at 09:55 -0700, David Brownell wrote:
> > On Friday 17 August 2007, Kay Sievers wrote:
> > > Again,
> >
> > "Again"?
>
> We exchanges several mails a few weeks ago after the Debian bug caused
> by a modprobe loop.
Which has been
On Fri, 2007-08-17 at 09:55 -0700, David Brownell wrote:
> On Friday 17 August 2007, Kay Sievers wrote:
> > Again,
>
> "Again"?
We exchanges several mails a few weeks ago after the Debian bug caused
by a modprobe loop.
> > the only sane solution is to provide MODALIAS="platform:"
> > from the
On Friday 17 August 2007, Kay Sievers wrote:
> Again,
"Again"?
> the only sane solution is to provide MODALIAS="platform:"
> from the platform bus, and adding the aliases to drivers who support
> autoloading. Modalias strings are not free-text strings, they are
> required to be prefixed by the
On 8/17/07, Atsushi Nemoto <[EMAIL PROTECTED]> wrote:
> On Fri, 17 Aug 2007 09:02:00 -0700, David Brownell <[EMAIL PROTECTED]> wrote:
> > Because for some reason the driver name isn't rtc-ds1742 ...
> >
> > My preferred style for such patches puts the MODULE_ALIAS up
> > near the strange driver nam
On Friday 17 August 2007, Atsushi Nemoto wrote:
>
> > My preferred style for such patches puts the MODULE_ALIAS up
> > near the strange driver name, so it's more clear what's going
> > on. Putting all the MODULE_*() stuff at the end of the file
> > gets confusing in this case.
>
> OK, then I sho
On Fri, 17 Aug 2007 09:02:00 -0700, David Brownell <[EMAIL PROTECTED]> wrote:
> Because for some reason the driver name isn't rtc-ds1742 ...
>
> My preferred style for such patches puts the MODULE_ALIAS up
> near the strange driver name, so it's more clear what's going
> on. Putting all the MODUL
On Fri, 17 Aug 2007 17:37:01 +0200 (CEST), Jan Engelhardt <[EMAIL PROTECTED]>
wrote:
> >Most busses don't have managed device IDs like PCI, USB, or PNP.
> >
> >The platform, spi, and i2c busses use the driver name, which is
> >obviously managed within the scope of all Linux drivers.
> >
> Yeah but
On Friday 17 August 2007, Jan Engelhardt wrote:
> >Most busses don't have managed device IDs like PCI, USB, or PNP.
> >
> >The platform, spi, and i2c busses use the driver name, which is
> >obviously managed within the scope of all Linux drivers.
> >
> Yeah but that does not tell me why it needs th
On Aug 17 2007 08:23, David Brownell wrote:
>On Friday 17 August 2007, Jan Engelhardt wrote:
>> On Aug 17 2007 01:06, Atsushi Nemoto wrote:
>> >Add an MODULE_ALIAS() to make this platform driver hotplug-aware.
>> >
>> >...
>> >+MODULE_ALIAS("ds1742");
>>
>> Why exactly is this needed? What script
On Friday 17 August 2007, Jan Engelhardt wrote:
> On Aug 17 2007 01:06, Atsushi Nemoto wrote:
> >Add an MODULE_ALIAS() to make this platform driver hotplug-aware.
> >
> >...
> >+MODULE_ALIAS("ds1742");
>
> Why exactly is this needed? What script refers to the module as ds1742 instead
> of rtc-ds17
On Aug 17 2007 01:06, Atsushi Nemoto wrote:
>Add an MODULE_ALIAS() to make this platform driver hotplug-aware.
>
>Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]>
>---
>diff --git a/drivers/rtc/rtc-ds1742.c b/drivers/rtc/rtc-ds1742.c
>index b2e5481..4bd22dc 100644
>--- a/drivers/rtc/rtc-ds1742.c
Add an MODULE_ALIAS() to make this platform driver hotplug-aware.
Signed-off-by: Atsushi Nemoto <[EMAIL PROTECTED]>
---
diff --git a/drivers/rtc/rtc-ds1742.c b/drivers/rtc/rtc-ds1742.c
index b2e5481..4bd22dc 100644
--- a/drivers/rtc/rtc-ds1742.c
+++ b/drivers/rtc/rtc-ds1742.c
@@ -273,3 +273,4 @@ M
23 matches
Mail list logo
