Re: [rtc-linux] [PATCH] rtc: add support for maxim dallas rtc ds1347

2014-03-21 Thread Alessandro Zummo
On Fri, 21 Mar 2014 20:05:40 +0530 RAGHAVENDRA GANIGA wrote: > From 0fd7f9ab5c0cb5e857b7b4d6893a8e68ac7763fd Mon Sep 17 00:00:00 2001 > From: Raghavendra Ganiga > Date: Fri, 21 Mar 2014 19:53:36 +0530 > Subject: [PATCH] rtc: add support for maxim dallas rtc ds1347 > > This

[PATCH] rtc: add support for maxim dallas rtc ds1347

2014-03-21 Thread RAGHAVENDRA GANIGA
>From 0fd7f9ab5c0cb5e857b7b4d6893a8e68ac7763fd Mon Sep 17 00:00:00 2001 From: Raghavendra Ganiga Date: Fri, 21 Mar 2014 19:53:36 +0530 Subject: [PATCH] rtc: add support for maxim dallas rtc ds1347 This is a patch to add support for maxim dallas rtc ds1347 Signed-off-by: Raghavendra Chan

[PATCH] rtc: add support for maxim dallas rtc ds1347

2014-03-21 Thread RAGHAVENDRA GANIGA
From 0fd7f9ab5c0cb5e857b7b4d6893a8e68ac7763fd Mon Sep 17 00:00:00 2001 From: Raghavendra Ganiga ravi23gan...@gmail.com Date: Fri, 21 Mar 2014 19:53:36 +0530 Subject: [PATCH] rtc: add support for maxim dallas rtc ds1347 This is a patch to add support for maxim dallas rtc ds1347 Signed-off

Re: [rtc-linux] [PATCH] rtc: add support for maxim dallas rtc ds1347

2014-03-21 Thread Alessandro Zummo
rtc ds1347 This is a patch to add support for maxim dallas rtc ds1347 Signed-off-by: Raghavendra Chandra Ganiga ravi23gan...@gmail.com Acked-by: Alessandro Zummo a.zu...@towertech.it -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it

Re: [PATCH] rtc: add support for maxim dallas rtc ds1347

2014-03-20 Thread Joe Perches
On Thu, 2014-03-20 at 22:01 +0100, Alessandro Zummo wrote: > On Thu, 20 Mar 2014 12:19:55 -0700 > Joe Perches wrote: > > This depends on how long you want to live, but it could be > > while (dt->tm_year >= 100) > dt->tm_year % 100 ? Sure, if you don't mind the divide. -- To unsubscribe

Re: [PATCH] rtc: add support for maxim dallas rtc ds1347

2014-03-20 Thread Alessandro Zummo
On Thu, 20 Mar 2014 12:19:55 -0700 Joe Perches wrote: > This depends on how long you want to live, but it could be > > while (dt->tm_year >= 100) dt->tm_year % 100 ? -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To

Re: [PATCH] rtc: add support for maxim dallas rtc ds1347

2014-03-20 Thread Joe Perches
On Fri, 2014-03-21 at 00:30 +0530, RAGHAVENDRA GANIGA wrote: > This is a patch to add support for > maxim dallas rtc ds1347 [] > diff --git a/drivers/rtc/rtc-ds1347.c b/drivers/rtc/rtc-ds1347.c [] > +static int ds1347_read_time(struct device *dev, struct rtc_time *dt) > +{ []

[PATCH] rtc: add support for maxim dallas rtc ds1347

2014-03-20 Thread RAGHAVENDRA GANIGA
>From f18fc68778c210863ca0968e4448375c89e9bb06 Mon Sep 17 00:00:00 2001 From: Raghavendra Ganiga Date: Fri, 21 Mar 2014 00:22:32 +0530 Subject: [PATCH] rtc: add support for maxim dallas rtc ds1347 This is a patch to add support for maxim dallas rtc ds1347 Signed-off-by: Raghavendra Chan

Re: [PATCH] rtc: add support for maxim dallas rtc ds1347

2014-03-20 Thread Alessandro Zummo
On Thu, 20 Mar 2014 21:55:33 +0530 RAGHAVENDRA GANIGA wrote: Thanks for your submission! just a few comments below: > --- > drivers/rtc/Kconfig | 12 > drivers/rtc/Makefile |1 + > drivers/rtc/rtc-ds1347.c | 175 > ++ > 3

[PATCH] rtc: add support for maxim dallas rtc ds1347

2014-03-20 Thread RAGHAVENDRA GANIGA
>From 64f99d0497c6de5157bc4931b47aadc266f5961e Mon Sep 17 00:00:00 2001 From: Raghavendra Ganiga Date: Thu, 20 Mar 2014 00:53:30 +0530 Subject: [PATCH] rtc: add support for maxim dallas rtc ds1347 This is a patch to add support for maxim dallas rtc ds1347 Signed-off-by: Raghavendra Chan

[PATCH] rtc: add support for maxim dallas rtc ds1347

2014-03-20 Thread RAGHAVENDRA GANIGA
From 64f99d0497c6de5157bc4931b47aadc266f5961e Mon Sep 17 00:00:00 2001 From: Raghavendra Ganiga ravi23gan...@gmail.com Date: Thu, 20 Mar 2014 00:53:30 +0530 Subject: [PATCH] rtc: add support for maxim dallas rtc ds1347 This is a patch to add support for maxim dallas rtc ds1347 Signed-off

Re: [PATCH] rtc: add support for maxim dallas rtc ds1347

2014-03-20 Thread Alessandro Zummo
On Thu, 20 Mar 2014 21:55:33 +0530 RAGHAVENDRA GANIGA ravi23gan...@gmail.com wrote: Thanks for your submission! just a few comments below: --- drivers/rtc/Kconfig | 12 drivers/rtc/Makefile |1 + drivers/rtc/rtc-ds1347.c | 175

[PATCH] rtc: add support for maxim dallas rtc ds1347

2014-03-20 Thread RAGHAVENDRA GANIGA
From f18fc68778c210863ca0968e4448375c89e9bb06 Mon Sep 17 00:00:00 2001 From: Raghavendra Ganiga ravi23gan...@gmail.com Date: Fri, 21 Mar 2014 00:22:32 +0530 Subject: [PATCH] rtc: add support for maxim dallas rtc ds1347 This is a patch to add support for maxim dallas rtc ds1347 Signed-off

Re: [PATCH] rtc: add support for maxim dallas rtc ds1347

2014-03-20 Thread Joe Perches
On Fri, 2014-03-21 at 00:30 +0530, RAGHAVENDRA GANIGA wrote: This is a patch to add support for maxim dallas rtc ds1347 [] diff --git a/drivers/rtc/rtc-ds1347.c b/drivers/rtc/rtc-ds1347.c [] +static int ds1347_read_time(struct device *dev, struct rtc_time *dt) +{ [] + /* year in linux

Re: [PATCH] rtc: add support for maxim dallas rtc ds1347

2014-03-20 Thread Alessandro Zummo
On Thu, 20 Mar 2014 12:19:55 -0700 Joe Perches j...@perches.com wrote: This depends on how long you want to live, but it could be while (dt-tm_year = 100) dt-tm_year % 100 ? -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it --

Re: [PATCH] rtc: add support for maxim dallas rtc ds1347

2014-03-20 Thread Joe Perches
On Thu, 2014-03-20 at 22:01 +0100, Alessandro Zummo wrote: On Thu, 20 Mar 2014 12:19:55 -0700 Joe Perches j...@perches.com wrote: This depends on how long you want to live, but it could be while (dt-tm_year = 100) dt-tm_year % 100 ? Sure, if you don't mind the divide. -- To