Re: [PATCH] rtc: cmos: Fix accidentally enabling rtc channel

2013-05-29 Thread dbasehore .
I'm still debugging all of the issues, but allowing the cmos interrupt handler to run before resuming caused some issues where the timer for the alarm was not removed. This would cause other, later timers to not be cleared, so utilities such as hwclock would time out when waiting for the update int

Re: [PATCH] rtc: cmos: Fix accidentally enabling rtc channel

2013-05-29 Thread Andrew Morton
On Wed, 22 May 2013 18:04:05 -0700 Derek Basehore wrote: > During resume, we call hpet_rtc_timer_init after masking an irq bit in hpet. > This will cause the call to hpet_disable_rtc_channel to be undone if RTC_AIE > is > the only bit not masked. What were the user-visible runtime effects of t

[PATCH] rtc: cmos: Fix accidentally enabling rtc channel

2013-05-22 Thread Derek Basehore
During resume, we call hpet_rtc_timer_init after masking an irq bit in hpet. This will cause the call to hpet_disable_rtc_channel to be undone if RTC_AIE is the only bit not masked. Signed-off-by: Derek Basehore --- drivers/rtc/rtc-cmos.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)