Re: [PATCH] rtc: ds1307: Fix alarm programming for mcp794xx

2015-10-27 Thread Alexandre Belloni
On 23/10/2015 at 09:29:57 +0300, Tero Kristo wrote : > mcp794xx alarm registers must be written in BCD format. However, the > alarm programming logic neglected this by adding one to the value > after bin2bcd conversion has been already done, writing bad values > to month register in case the alarm

Re: [PATCH] rtc: ds1307: Fix alarm programming for mcp794xx

2015-10-24 Thread Nishanth Menon
On 10/23/2015 01:29 AM, Tero Kristo wrote: > mcp794xx alarm registers must be written in BCD format. However, the > alarm programming logic neglected this by adding one to the value > after bin2bcd conversion has been already done, writing bad values > to month register in case the alarm being set

[PATCH] rtc: ds1307: Fix alarm programming for mcp794xx

2015-10-22 Thread Tero Kristo
mcp794xx alarm registers must be written in BCD format. However, the alarm programming logic neglected this by adding one to the value after bin2bcd conversion has been already done, writing bad values to month register in case the alarm being set is in October. In this case, the alarm month value