VS: [PATCH] rtc: ds1307: add trickle charger device tree binding

2014-09-09 Thread Vaittinen, Matti (NSN - FI/Oulu)
Lähettäjä: ext Jason Cooper > meh. The presence or absence of the property should express the boolean. > > The safe state should be the default (property absent), and the property name should describe the state when the property is present. This is What the v5 of patch does. It introduces boo

Re: [PATCH] rtc: ds1307: add trickle charger device tree binding

2014-09-09 Thread Jason Cooper
On Tue, Sep 09, 2014 at 01:34:25PM +0200, Pavel Machek wrote: ... > > _Maybe_ > > diode-connected = <1>; or > > diode-connected = <0>; > > That should work. meh. The presence or absence of the property should express the boolean. The safe state should be the default (property absent), and th

Re: [PATCH] rtc: ds1307: add trickle charger device tree binding

2014-09-09 Thread Pavel Machek
Hi! > > > > trickle-resistor-ohms = <250> > > > > diode-connected; > > > > > > > > That's easy for a human to write and/or validate, we can easily extend > > > > it in future, requires no proliferation of macros, and describes the > > > > hardware rather than telling software what to do. > > > >

Re: [PATCH] rtc: ds1307: add trickle charger device tree binding

2014-09-08 Thread Matti Vaittinen
On Mon, Sep 08, 2014 at 03:58:25PM +0100, ext Mark Rutland wrote: > On Mon, Sep 08, 2014 at 02:52:42PM +0100, Pavel Machek wrote: > > > I would suggest we have two properties that describe the resistor's > > > rating and whether or not there is a diode: > > > > > > trickle-resistor-ohms = <250> >

Re: [PATCH] rtc: ds1307: add trickle charger device tree binding

2014-09-08 Thread Mark Rutland
On Mon, Sep 08, 2014 at 02:52:42PM +0100, Pavel Machek wrote: > Hi! > > > I would suggest we have two properties that describe the resistor's > > rating and whether or not there is a diode: > > > > trickle-resistor-ohms = <250> > > diode-connected; > > > > That's easy for a human to write and/or

Re: [PATCH] rtc: ds1307: add trickle charger device tree binding

2014-09-08 Thread Pavel Machek
Hi! > I would suggest we have two properties that describe the resistor's > rating and whether or not there is a diode: > > trickle-resistor-ohms = <250> > diode-connected; > > That's easy for a human to write and/or validate, we can easily extend > it in future, requires no proliferation of mac

Re: [PATCH] rtc: ds1307: add trickle charger device tree binding

2014-08-29 Thread Mark Rutland
On Fri, Aug 29, 2014 at 01:48:29PM +0100, Jason Cooper wrote: > On Fri, Aug 29, 2014 at 01:42:16PM +0100, Mark Rutland wrote: > > On Fri, Aug 29, 2014 at 01:24:52PM +0100, Jason Cooper wrote: > > > On Fri, Aug 29, 2014 at 11:40:02AM +0100, Mark Rutland wrote: > ... > Someone wrote: > > > > > > > >

Re: [PATCH] rtc: ds1307: add trickle charger device tree binding

2014-08-29 Thread Matti Vaittinen
On Fri, Aug 29, 2014 at 08:48:29AM -0400, ext Jason Cooper wrote: > On Fri, Aug 29, 2014 at 01:42:16PM +0100, Mark Rutland wrote: > > On Fri, Aug 29, 2014 at 01:24:52PM +0100, Jason Cooper wrote: > > > On Fri, Aug 29, 2014 at 11:40:02AM +0100, Mark Rutland wrote: > ... > Someone wrote: > > > > > >

Re: [PATCH] rtc: ds1307: add trickle charger device tree binding

2014-08-29 Thread Jason Cooper
On Fri, Aug 29, 2014 at 01:42:16PM +0100, Mark Rutland wrote: > On Fri, Aug 29, 2014 at 01:24:52PM +0100, Jason Cooper wrote: > > On Fri, Aug 29, 2014 at 11:40:02AM +0100, Mark Rutland wrote: ... Someone wrote: > > > > > > > http://datasheets.maximintegrated.com/en/ds/DS1307.pdf > > > > > > > http:

Re: [PATCH] rtc: ds1307: add trickle charger device tree binding

2014-08-29 Thread Mark Rutland
On Fri, Aug 29, 2014 at 01:24:52PM +0100, Jason Cooper wrote: > On Fri, Aug 29, 2014 at 11:40:02AM +0100, Mark Rutland wrote: > > On Fri, Aug 29, 2014 at 08:34:25AM +0100, Matti Vaittinen wrote: > > > On Thu, Aug 28, 2014 at 10:40:34AM -0700, ext Guenter Roeck wrote: > > > > On Thu, Aug 28, 2014 at

Re: [PATCH] rtc: ds1307: add trickle charger device tree binding

2014-08-29 Thread Jason Cooper
On Fri, Aug 29, 2014 at 11:40:02AM +0100, Mark Rutland wrote: > On Fri, Aug 29, 2014 at 08:34:25AM +0100, Matti Vaittinen wrote: > > On Thu, Aug 28, 2014 at 10:40:34AM -0700, ext Guenter Roeck wrote: > > > On Thu, Aug 28, 2014 at 01:28:42PM -0400, Jason Cooper wrote: > > > > On Thu, Aug 28, 2014 at

Re: [PATCH] rtc: ds1307: add trickle charger device tree binding

2014-08-29 Thread Matti Vaittinen
On Fri, Aug 29, 2014 at 11:40:02AM +0100, ext Mark Rutland wrote: > On Fri, Aug 29, 2014 at 08:34:25AM +0100, Matti Vaittinen wrote: > > On Thu, Aug 28, 2014 at 10:40:34AM -0700, ext Guenter Roeck wrote: > > > On Thu, Aug 28, 2014 at 01:28:42PM -0400, Jason Cooper wrote: > > > > On Thu, Aug 28, 201

Re: [PATCH] rtc: ds1307: add trickle charger device tree binding

2014-08-29 Thread Mark Rutland
On Fri, Aug 29, 2014 at 08:34:25AM +0100, Matti Vaittinen wrote: > On Thu, Aug 28, 2014 at 10:40:34AM -0700, ext Guenter Roeck wrote: > > On Thu, Aug 28, 2014 at 01:28:42PM -0400, Jason Cooper wrote: > > > On Thu, Aug 28, 2014 at 09:48:25AM -0700, Guenter Roeck wrote: > > > > On Thu, Aug 28, 2014 a

Re: [PATCH] rtc: ds1307: add trickle charger device tree binding

2014-08-28 Thread Matti Vaittinen
On Thu, Aug 28, 2014 at 10:40:34AM -0700, ext Guenter Roeck wrote: > On Thu, Aug 28, 2014 at 01:28:42PM -0400, Jason Cooper wrote: > > On Thu, Aug 28, 2014 at 09:48:25AM -0700, Guenter Roeck wrote: > > > On Thu, Aug 28, 2014 at 05:10:25PM +0100, Mark Rutland wrote: > > > > On Thu, Aug 28, 2014 at 0

Re: [PATCH] rtc: ds1307: add trickle charger device tree binding

2014-08-28 Thread Matti Vaittinen
On Thu, Aug 28, 2014 at 01:59:15PM +0100, ext Mark Rutland wrote: > On Thu, Aug 28, 2014 at 01:42:44PM +0100, Matti Vaittinen wrote: > > Patch adding support for specifying trickle charger setup from device > > tree. Patch is based on linux-next tree. > > > > > > Some DS13XX devices have "trickle

Re: [PATCH] rtc: ds1307: add trickle charger device tree binding

2014-08-28 Thread Guenter Roeck
On Thu, Aug 28, 2014 at 01:28:42PM -0400, Jason Cooper wrote: > On Thu, Aug 28, 2014 at 09:48:25AM -0700, Guenter Roeck wrote: > > On Thu, Aug 28, 2014 at 05:10:25PM +0100, Mark Rutland wrote: > > > On Thu, Aug 28, 2014 at 04:51:57PM +0100, Guenter Roeck wrote: > > > > On Thu, Aug 28, 2014 at 01:59

Re: [PATCH] rtc: ds1307: add trickle charger device tree binding

2014-08-28 Thread Jason Cooper
On Thu, Aug 28, 2014 at 09:48:25AM -0700, Guenter Roeck wrote: > On Thu, Aug 28, 2014 at 05:10:25PM +0100, Mark Rutland wrote: > > On Thu, Aug 28, 2014 at 04:51:57PM +0100, Guenter Roeck wrote: > > > On Thu, Aug 28, 2014 at 01:59:15PM +0100, Mark Rutland wrote: > > > > On Thu, Aug 28, 2014 at 01:42

Re: [PATCH] rtc: ds1307: add trickle charger device tree binding

2014-08-28 Thread Guenter Roeck
On Thu, Aug 28, 2014 at 05:10:25PM +0100, Mark Rutland wrote: > On Thu, Aug 28, 2014 at 04:51:57PM +0100, Guenter Roeck wrote: > > On Thu, Aug 28, 2014 at 01:59:15PM +0100, Mark Rutland wrote: > > > On Thu, Aug 28, 2014 at 01:42:44PM +0100, Matti Vaittinen wrote: > > > > Patch adding support for sp

Re: [PATCH] rtc: ds1307: add trickle charger device tree binding

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 04:51:57PM +0100, Guenter Roeck wrote: > On Thu, Aug 28, 2014 at 01:59:15PM +0100, Mark Rutland wrote: > > On Thu, Aug 28, 2014 at 01:42:44PM +0100, Matti Vaittinen wrote: > > > Patch adding support for specifying trickle charger setup from device > > > tree. Patch is based

Re: [PATCH] rtc: ds1307: add trickle charger device tree binding

2014-08-28 Thread Guenter Roeck
On Thu, Aug 28, 2014 at 01:59:15PM +0100, Mark Rutland wrote: > On Thu, Aug 28, 2014 at 01:42:44PM +0100, Matti Vaittinen wrote: > > Patch adding support for specifying trickle charger setup from device > > tree. Patch is based on linux-next tree. > > > > > > Some DS13XX devices have "trickle cha

Re: [PATCH] rtc: ds1307: add trickle charger device tree binding

2014-08-28 Thread Mark Rutland
On Thu, Aug 28, 2014 at 01:42:44PM +0100, Matti Vaittinen wrote: > Patch adding support for specifying trickle charger setup from device > tree. Patch is based on linux-next tree. > > > Some DS13XX devices have "trickle chargers". Introduce a device tree binding > for specifying the setup and reg

[PATCH] rtc: ds1307: add trickle charger device tree binding

2014-08-28 Thread Matti Vaittinen
Patch adding support for specifying trickle charger setup from device tree. Patch is based on linux-next tree. Some DS13XX devices have "trickle chargers". Introduce a device tree binding for specifying the setup and register values. Signed-off-by: Matti Vaittinen --- .../devicetree/bindings/i