Re: [PATCH] rtc: pcf8563 fix: return -EINVAL if we read an invalid time.

2015-05-27 Thread Alexandre Belloni
Hi, On 25/05/2015 at 11:51:14 +0200, Jan Kardell wrote : > @@ -202,8 +202,9 @@ static int pcf8563_get_datetime(struct i2c_client > *client, struct rtc_time *tm) > > if (buf[PCF8563_REG_SC] & PCF8563_SC_LV) { > pcf8563->voltage_low = 1; > - dev_info(&client->dev,

[PATCH] rtc: pcf8563 fix: return -EINVAL if we read an invalid time.

2015-05-25 Thread Jan Kardell
Return -EINVAL if the voltage low bit is set or the time looks invalid to avoid getting a bogus time at boot. There was a comment stating that util-linux hwclock refuses to set a new time if we return an error code on read, but at least the current version do set the time as expected. Anyway most r