Re: [PATCH] rtc: report time-retrieval errors when updating alarm

2019-10-21 Thread Brian Norris
On Mon, Oct 21, 2019 at 10:48 AM Alexandre Belloni wrote: > On 21/10/2019 10:20:08-0700, Brian Norris wrote: > > Hi Alexandre! > > > > On Mon, Oct 21, 2019 at 9:11 AM Alexandre Belloni > > wrote: > > > On 21/05/2018 09:42:22-0700, Brian Norris wrote: > > > > __rtc_read_time() can fail (e.g., if

Re: [PATCH] rtc: report time-retrieval errors when updating alarm

2019-10-21 Thread Alexandre Belloni
On 21/10/2019 10:20:08-0700, Brian Norris wrote: > Hi Alexandre! > > On Mon, Oct 21, 2019 at 9:11 AM Alexandre Belloni > wrote: > > On 21/05/2018 09:42:22-0700, Brian Norris wrote: > > > __rtc_read_time() can fail (e.g., if the RTC uses an unreliable medium). > > > When it does, we don't report

Re: [PATCH] rtc: report time-retrieval errors when updating alarm

2019-10-21 Thread Brian Norris
Hi Alexandre! On Mon, Oct 21, 2019 at 9:11 AM Alexandre Belloni wrote: > On 21/05/2018 09:42:22-0700, Brian Norris wrote: > > __rtc_read_time() can fail (e.g., if the RTC uses an unreliable medium). > > When it does, we don't report the error, but instead calculate a > > 1-second alarm based on

Re: [PATCH] rtc: report time-retrieval errors when updating alarm

2019-10-21 Thread Alexandre Belloni
Hello Brian, On 21/05/2018 09:42:22-0700, Brian Norris wrote: > __rtc_read_time() can fail (e.g., if the RTC uses an unreliable medium). > When it does, we don't report the error, but instead calculate a > 1-second alarm based on the potentially-garbage 'tm' (in practice, > __rtc_read_time()

[PATCH] rtc: report time-retrieval errors when updating alarm

2018-05-21 Thread Brian Norris
__rtc_read_time() can fail (e.g., if the RTC uses an unreliable medium). When it does, we don't report the error, but instead calculate a 1-second alarm based on the potentially-garbage 'tm' (in practice, __rtc_read_time() zeroes out the time first, so it's likely to still be all 0). Let's

[PATCH] rtc: report time-retrieval errors when updating alarm

2018-05-21 Thread Brian Norris
__rtc_read_time() can fail (e.g., if the RTC uses an unreliable medium). When it does, we don't report the error, but instead calculate a 1-second alarm based on the potentially-garbage 'tm' (in practice, __rtc_read_time() zeroes out the time first, so it's likely to still be all 0). Let's