Re: [PATCH] rtc: sun6i: ensure clk_data is kfree'd on error

2017-07-30 Thread Alexandre Belloni
On 19/07/2017 at 18:48:27 +0100, Colin Ian King wrote: > On 19/07/17 18:32, Alexandre Belloni wrote: > > Hi, > > > > On 19/07/2017 at 17:57:02 +0100, Colin King wrote: > >> From: Colin Ian King > >> > >> There are two error return paths that do not kfree clk_data and > >> we end up with a memory

Re: [PATCH] rtc: sun6i: ensure clk_data is kfree'd on error

2017-07-19 Thread Colin Ian King
On 19/07/17 18:32, Alexandre Belloni wrote: > Hi, > > On 19/07/2017 at 17:57:02 +0100, Colin King wrote: >> From: Colin Ian King >> >> There are two error return paths that do not kfree clk_data and >> we end up with a memory leak. Fix these with a kfree error exit >> path. >> >> Detected by Cove

Re: [PATCH] rtc: sun6i: ensure clk_data is kfree'd on error

2017-07-19 Thread Alexandre Belloni
Hi, On 19/07/2017 at 17:57:02 +0100, Colin King wrote: > From: Colin Ian King > > There are two error return paths that do not kfree clk_data and > we end up with a memory leak. Fix these with a kfree error exit > path. > > Detected by CoverityScan, CID#1402959 ("Resource Leak") > I think tha

[PATCH] rtc: sun6i: ensure clk_data is kfree'd on error

2017-07-19 Thread Colin King
From: Colin Ian King There are two error return paths that do not kfree clk_data and we end up with a memory leak. Fix these with a kfree error exit path. Detected by CoverityScan, CID#1402959 ("Resource Leak") Signed-off-by: Colin Ian King --- drivers/rtc/rtc-sun6i.c | 8 ++-- 1 file cha