Re: [PATCH] rtmutex: Drop pointless static qualifier in rt_mutex_adjust_prio_chain()

2018-08-07 Thread kbuild test robot
Hi Mao, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/locking/core] [also build test WARNING on v4.18-rc8 next-20180807] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] rtmutex: Drop pointless static qualifier in rt_mutex_adjust_prio_chain()

2018-08-07 Thread kbuild test robot
Hi Mao, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/locking/core] [also build test WARNING on v4.18-rc8 next-20180807] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] rtmutex: Drop pointless static qualifier in rt_mutex_adjust_prio_chain()

2018-08-07 Thread Dan Carpenter
This is obviously wrong and you need to at least compile your patches... regards, dan carpenter

Re: [PATCH] rtmutex: Drop pointless static qualifier in rt_mutex_adjust_prio_chain()

2018-08-07 Thread Dan Carpenter
This is obviously wrong and you need to at least compile your patches... regards, dan carpenter

Re: [PATCH] rtmutex: Drop pointless static qualifier in rt_mutex_adjust_prio_chain()

2018-08-07 Thread Julia Lawall
On Tue, 7 Aug 2018, Mao Wenan wrote: > There is no need to have the 'T *v' variable static > since new value always be assigned before use it. The code is: static int prev_max; /* * Print this only once. If the admin changes the limit,

Re: [PATCH] rtmutex: Drop pointless static qualifier in rt_mutex_adjust_prio_chain()

2018-08-07 Thread Julia Lawall
On Tue, 7 Aug 2018, Mao Wenan wrote: > There is no need to have the 'T *v' variable static > since new value always be assigned before use it. The code is: static int prev_max; /* * Print this only once. If the admin changes the limit,

[PATCH] rtmutex: Drop pointless static qualifier in rt_mutex_adjust_prio_chain()

2018-08-07 Thread Mao Wenan
There is no need to have the 'T *v' variable static since new value always be assigned before use it. Signed-off-by: Mao Wenan --- kernel/locking/rtmutex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c index

[PATCH] rtmutex: Drop pointless static qualifier in rt_mutex_adjust_prio_chain()

2018-08-07 Thread Mao Wenan
There is no need to have the 'T *v' variable static since new value always be assigned before use it. Signed-off-by: Mao Wenan --- kernel/locking/rtmutex.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/locking/rtmutex.c b/kernel/locking/rtmutex.c index