Re: [PATCH] rwsem: fix commas in initialisation

2020-07-13 Thread Alexey Dobriyan
On Mon, Jul 13, 2020 at 01:51:41PM +0200, Peter Zijlstra wrote: > On Sat, Jul 11, 2020 at 05:59:54PM +0300, Alexey Dobriyan wrote: > > Leading comma prevents arbitrary reordering of initialisation clauses. > > The whole point of C99 initialisation is to allow any such reordering. > > I'm

Re: [PATCH] rwsem: fix commas in initialisation

2020-07-13 Thread Peter Zijlstra
On Sat, Jul 11, 2020 at 05:59:54PM +0300, Alexey Dobriyan wrote: > Leading comma prevents arbitrary reordering of initialisation clauses. > The whole point of C99 initialisation is to allow any such reordering. I'm conflicted on this argument, the only reason I'd be inclined to take this patch is

[PATCH] rwsem: fix commas in initialisation

2020-07-11 Thread Alexey Dobriyan
Leading comma prevents arbitrary reordering of initialisation clauses. The whole point of C99 initialisation is to allow any such reordering. Signed-off-by: Alexey Dobriyan --- include/linux/rwsem.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) --- a/include/linux/rwsem.h