Re: [PATCH] s390/zcrypt: remove the exporting of ap_query_configuration

2019-07-11 Thread Vasily Gorbik
On Wed, Jul 10, 2019 at 08:44:53AM +0200, Harald Freudenberger wrote: > On 09.07.19 14:25, Denis Efremov wrote: > > The function ap_query_configuration is declared static and marked > > EXPORT_SYMBOL, which is at best an odd combination. Because the > > function is not used outside of the drivers/s

Re: [PATCH] s390/zcrypt: remove the exporting of ap_query_configuration

2019-07-09 Thread Harald Freudenberger
On 09.07.19 14:25, Denis Efremov wrote: > The function ap_query_configuration is declared static and marked > EXPORT_SYMBOL, which is at best an odd combination. Because the > function is not used outside of the drivers/s390/crypto/ap_bus.c > file it is defined in, this commit removes the EXPORT_SY

[PATCH] s390/zcrypt: remove the exporting of ap_query_configuration

2019-07-09 Thread Denis Efremov
The function ap_query_configuration is declared static and marked EXPORT_SYMBOL, which is at best an odd combination. Because the function is not used outside of the drivers/s390/crypto/ap_bus.c file it is defined in, this commit removes the EXPORT_SYMBOL() marking. Fixes: f1b0a4343c41 ("s390/zcry