Re: [PATCH] s390 appldata_base: Remove module_exit function and modular stuff

2007-08-24 Thread Martin Schwidefsky
On Fri, 2007-08-24 at 04:21 +0530, Satyam Sharma wrote: > > I has been a module once for debugging purposes That the module_exit > > function still exists is "historical". We can remove it since it is dead > > code. > > Thanks, fair enough. Does this mean you're acking them -- I'd prefer both > th

Re: [PATCH] s390 appldata_base: Remove module_exit function and modular stuff

2007-08-23 Thread Satyam Sharma
Hi Martin, On Thu, 23 Aug 2007, Martin Schwidefsky wrote: > On Thu, 2007-08-23 at 07:51 +0530, Satyam Sharma wrote: > > > BTW the __exit module_exit function appldata_exit() of this driver > > > fails to unregister_hotcpu_notifier() the notifier_block that was > > > registered by appldata_init(

Re: [PATCH] s390 appldata_base: Remove module_exit function and modular stuff

2007-08-23 Thread Martin Schwidefsky
On Thu, 2007-08-23 at 07:51 +0530, Satyam Sharma wrote: > > BTW the __exit module_exit function appldata_exit() of this driver > > fails to unregister_hotcpu_notifier() the notifier_block that was > > registered by appldata_init() during module startup. This will lead > > to oops if hotplug notifi

[PATCH] s390 appldata_base: Remove module_exit function and modular stuff

2007-08-22 Thread Satyam Sharma
nt an __exit marked module_exit(appldata_exit) function in that case ?! [ On top of previous patch: ] [PATCH] s390 appldata_base: Remove module_exit function and modular stuff arch/s390/Kconfig tells us that CONFIG_APPLDATA_BASE is bool and hence can never be built modular. Given this, defin