Re: [PATCH] s5p-mfc: Don't try to put pm->clock if lookup failed

2016-05-02 Thread Javier Martinez Canillas
Hello Arnd, Thanks for your feedback. On 05/02/2016 02:41 PM, Arnd Bergmann wrote: > On Monday 02 May 2016 13:27:54 Javier Martinez Canillas wrote: >> Failing to get the struct s5p_mfc_pm .clock is a non-fatal error so the >> clock field can have a errno pointer value. But s5p_mfc_final_pm() only

Re: [PATCH] s5p-mfc: Don't try to put pm->clock if lookup failed

2016-05-02 Thread Arnd Bergmann
On Monday 02 May 2016 13:27:54 Javier Martinez Canillas wrote: > Failing to get the struct s5p_mfc_pm .clock is a non-fatal error so the > clock field can have a errno pointer value. But s5p_mfc_final_pm() only > checks if .clock is not NULL before attempting to unprepare and put it. > > This lead

[PATCH] s5p-mfc: Don't try to put pm->clock if lookup failed

2016-05-02 Thread Javier Martinez Canillas
Failing to get the struct s5p_mfc_pm .clock is a non-fatal error so the clock field can have a errno pointer value. But s5p_mfc_final_pm() only checks if .clock is not NULL before attempting to unprepare and put it. This leads to the following warning in clk_put() due s5p_mfc_final_pm(): WARNING: