On Mon, Nov 16, 2020 at 1:18 PM Steven Rostedt wrote:
>
> On Mon, 16 Nov 2020 13:10:57 -0800
> Sami Tolvanen wrote:
>
> > Clang doesn't warn about this as we're building a module, it just
> > generates a reference to a non-existing global "my_tramp" symbol,
> > because the one defined in inline a
On Mon, 16 Nov 2020 13:10:57 -0800
Sami Tolvanen wrote:
> Clang doesn't warn about this as we're building a module, it just
> generates a reference to a non-existing global "my_tramp" symbol,
> because the one defined in inline assembly has a local binding:
>
> $ readelf --symbols --wide ftrace-
On Mon, Nov 16, 2020 at 12:38 PM Steven Rostedt wrote:
>
> On Mon, 16 Nov 2020 12:10:10 -0800
> Sami Tolvanen wrote:
>
> > On Mon, Nov 16, 2020 at 8:39 AM Steven Rostedt wrote:
> > >
> > > On Fri, 13 Nov 2020 10:34:14 -0800
> > > Sami Tolvanen wrote:
> > >
> > > > my_tramp[12]? are declared as
On Mon, 16 Nov 2020 12:10:10 -0800
Sami Tolvanen wrote:
> On Mon, Nov 16, 2020 at 8:39 AM Steven Rostedt wrote:
> >
> > On Fri, 13 Nov 2020 10:34:14 -0800
> > Sami Tolvanen wrote:
> >
> > > my_tramp[12]? are declared as global functions in C, but they are not
> > > marked global in the inline
On Mon, Nov 16, 2020 at 8:39 AM Steven Rostedt wrote:
>
> On Fri, 13 Nov 2020 10:34:14 -0800
> Sami Tolvanen wrote:
>
> > my_tramp[12]? are declared as global functions in C, but they are not
> > marked global in the inline assembly definition. This mismatch confuses
> > Clang's Control-Flow Inte
On Fri, 13 Nov 2020 10:34:14 -0800
Sami Tolvanen wrote:
> my_tramp[12]? are declared as global functions in C, but they are not
> marked global in the inline assembly definition. This mismatch confuses
> Clang's Control-Flow Integrity checking. Fix the definitions by adding
> .globl.
>
Actually
On Fri, Nov 13, 2020 at 10:34:14AM -0800, Sami Tolvanen wrote:
> my_tramp[12]? are declared as global functions in C, but they are not
> marked global in the inline assembly definition. This mismatch confuses
> Clang's Control-Flow Integrity checking. Fix the definitions by adding
> .globl.
>
> Si
my_tramp[12]? are declared as global functions in C, but they are not
marked global in the inline assembly definition. This mismatch confuses
Clang's Control-Flow Integrity checking. Fix the definitions by adding
.globl.
Signed-off-by: Sami Tolvanen
---
samples/ftrace/ftrace-direct-modify.c | 2
8 matches
Mail list logo