Re: [PATCH] sata/mvebu: use #ifdef around suspend/resume code

2015-10-12 Thread Arnd Bergmann
On Monday 12 October 2015 15:27:03 Thomas Petazzoni wrote: > Arnd, > > On Mon, 12 Oct 2015 15:05:27 +0200, Arnd Bergmann wrote: > > > +#ifdef CONFIG_PM_SUSPEND > > Shouldn't this be CONFIG_PM_SLEEP ? > > The generic suspend/resume function in libahci_platform.c are defined > when CONFIG_PM_SLEE

Re: [PATCH] sata/mvebu: use #ifdef around suspend/resume code

2015-10-12 Thread Thomas Petazzoni
Arnd, On Mon, 12 Oct 2015 15:05:27 +0200, Arnd Bergmann wrote: > +#ifdef CONFIG_PM_SUSPEND Shouldn't this be CONFIG_PM_SLEEP ? The generic suspend/resume function in libahci_platform.c are defined when CONFIG_PM_SLEEP is enabled. Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux,

[PATCH] sata/mvebu: use #ifdef around suspend/resume code

2015-10-12 Thread Arnd Bergmann
The newly added suspend/resume implementation for ahci_mvebu causes a link error when CONFIG_PM_SUSPEND is disabled: ERROR: "ahci_platform_suspend_host" [drivers/ata/ahci_mvebu.ko] undefined! ERROR: "ahci_platform_resume_host" [drivers/ata/ahci_mvebu.ko] undefined! This adds the same #ifdef here