Re: Re: Re: Re: [PATCH] sata_dwc_460ex: Fix missing check in sata_dwc_isr

2021-03-03 Thread dinghao . liu
> On Tue, Mar 2, 2021 at 9:34 AM wrote: > > > On Mon, Mar 1, 2021 at 1:20 PM wrote: > > > > > On Mon, Mar 1, 2021 at 9:44 AM Dinghao Liu > > > > > wrote: > > ... > > > > > This issue is reported by my static analysis tool, so I don't have the > > > > vulnerable input currently. > > > > > >

Re: Re: Re: [PATCH] sata_dwc_460ex: Fix missing check in sata_dwc_isr

2021-03-02 Thread Andy Shevchenko
On Tue, Mar 2, 2021 at 9:34 AM wrote: > > On Mon, Mar 1, 2021 at 1:20 PM wrote: > > > > On Mon, Mar 1, 2021 at 9:44 AM Dinghao Liu > > > > wrote: ... > > > This issue is reported by my static analysis tool, so I don't have the > > > vulnerable input currently. > > > > Should we blindly

Re: Re: Re: [PATCH] sata_dwc_460ex: Fix missing check in sata_dwc_isr

2021-03-02 Thread dinghao . liu
> On Mon, Mar 1, 2021 at 1:20 PM wrote: > > > > > On Mon, Mar 1, 2021 at 9:44 AM Dinghao Liu wrote: > > > > > > > > ata_qc_from_tag() may return a null pointer and further lead to > > > > null-pointer-dereference. Add a return value check to avoid such case. > > > > > > Can you elaborate more on

Re: Re: [PATCH] sata_dwc_460ex: Fix missing check in sata_dwc_isr

2021-03-01 Thread Andy Shevchenko
On Mon, Mar 1, 2021 at 1:20 PM wrote: > > > On Mon, Mar 1, 2021 at 9:44 AM Dinghao Liu wrote: > > > > > > ata_qc_from_tag() may return a null pointer and further lead to > > > null-pointer-dereference. Add a return value check to avoid such case. > > > > Can you elaborate more on this? Is it a

Re: Re: [PATCH] sata_dwc_460ex: Fix missing check in sata_dwc_isr

2021-03-01 Thread dinghao . liu
> On Mon, Mar 1, 2021 at 9:44 AM Dinghao Liu wrote: > > > > ata_qc_from_tag() may return a null pointer and further lead to > > null-pointer-dereference. Add a return value check to avoid such case. > > Can you elaborate more on this? Is it a real case? > I have a hardware, how can I reproduce

Re: [PATCH] sata_dwc_460ex: Fix missing check in sata_dwc_isr

2021-03-01 Thread Andy Shevchenko
On Mon, Mar 1, 2021 at 9:44 AM Dinghao Liu wrote: > > ata_qc_from_tag() may return a null pointer and further lead to > null-pointer-dereference. Add a return value check to avoid such case. Can you elaborate more on this? Is it a real case? I have a hardware, how can I reproduce this? -- With

[PATCH] sata_dwc_460ex: Fix missing check in sata_dwc_isr

2021-02-28 Thread Dinghao Liu
ata_qc_from_tag() may return a null pointer and further lead to null-pointer-dereference. Add a return value check to avoid such case. Signed-off-by: Dinghao Liu --- drivers/ata/sata_dwc_460ex.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git