Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

Quoting Sergei Shtylyov : On 06/30/2017 10:46 PM, Gustavo A. R. Silva wrote: Print error message and propagate the return value of platform_get_irq on failure. You should have probably mentioned that this function no longer returns 0 on error.

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

Quoting Sergei Shtylyov : On 06/30/2017 10:46 PM, Gustavo A. R. Silva wrote: Print error message and propagate the return value of platform_get_irq on failure. You should have probably mentioned that this function no longer returns 0 on error. Yeah, the patches looks good to me but

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

On 06/30/2017 10:46 PM, Gustavo A. R. Silva wrote: Print error message and propagate the return value of platform_get_irq on failure. You should have probably mentioned that this function no longer returns 0 on error. Yeah, the patches looks good to me but I'd really appreciate more

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

On 06/30/2017 10:46 PM, Gustavo A. R. Silva wrote: Print error message and propagate the return value of platform_get_irq on failure. You should have probably mentioned that this function no longer returns 0 on error. Yeah, the patches looks good to me but I'd really appreciate more

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

Hi Sergei, Quoting Sergei Shtylyov : On 06/30/2017 10:36 PM, Gustavo A. R. Silva wrote: Print error message and propagate the return value of platform_get_irq on failure. You should have probably mentioned that this function no longer returns 0 on

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

Hi Sergei, Quoting Sergei Shtylyov : On 06/30/2017 10:36 PM, Gustavo A. R. Silva wrote: Print error message and propagate the return value of platform_get_irq on failure. You should have probably mentioned that this function no longer returns 0 on error. Yeah, the patches looks good

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

Quoting "Gustavo A. R. Silva" : Hi Tejun, Sergei, Quoting Tejun Heo : On Fri, Jun 30, 2017 at 12:42:38PM +0300, Sergei Shtylyov wrote: Hello! On 6/30/2017 8:22 AM, Gustavo A. R. Silva wrote: Print error message and propagate the return value of

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

Quoting "Gustavo A. R. Silva" : Hi Tejun, Sergei, Quoting Tejun Heo : On Fri, Jun 30, 2017 at 12:42:38PM +0300, Sergei Shtylyov wrote: Hello! On 6/30/2017 8:22 AM, Gustavo A. R. Silva wrote: Print error message and propagate the return value of platform_get_irq on failure. You

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

On 06/30/2017 10:36 PM, Gustavo A. R. Silva wrote: > Print error message and propagate the return value of > platform_get_irq on failure. You should have probably mentioned that this function no longer returns 0 on error. Yeah, the patches looks good to me but I'd really appreciate more

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

On 06/30/2017 10:36 PM, Gustavo A. R. Silva wrote: > Print error message and propagate the return value of > platform_get_irq on failure. You should have probably mentioned that this function no longer returns 0 on error. Yeah, the patches looks good to me but I'd really appreciate more

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

Hi Tejun, Sergei, Quoting Tejun Heo : On Fri, Jun 30, 2017 at 12:42:38PM +0300, Sergei Shtylyov wrote: Hello! On 6/30/2017 8:22 AM, Gustavo A. R. Silva wrote: > Print error message and propagate the return value of > platform_get_irq on failure. You should have probably

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

Hi Tejun, Sergei, Quoting Tejun Heo : On Fri, Jun 30, 2017 at 12:42:38PM +0300, Sergei Shtylyov wrote: Hello! On 6/30/2017 8:22 AM, Gustavo A. R. Silva wrote: > Print error message and propagate the return value of > platform_get_irq on failure. You should have probably mentioned that

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

On 06/30/2017 12:42 PM, Sergei Shtylyov wrote: Print error message and propagate the return value of platform_get_irq on failure. You should have probably mentioned that this function no longer returns 0 on error. It's prolly also worth mentioning that enforcing the error # on return

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

On 06/30/2017 12:42 PM, Sergei Shtylyov wrote: Print error message and propagate the return value of platform_get_irq on failure. You should have probably mentioned that this function no longer returns 0 on error. It's prolly also worth mentioning that enforcing the error # on return

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

On Fri, Jun 30, 2017 at 12:42:38PM +0300, Sergei Shtylyov wrote: > Hello! > > On 6/30/2017 8:22 AM, Gustavo A. R. Silva wrote: > > > Print error message and propagate the return value of > > platform_get_irq on failure. > >You should have probably mentioned that this function no longer

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

On Fri, Jun 30, 2017 at 12:42:38PM +0300, Sergei Shtylyov wrote: > Hello! > > On 6/30/2017 8:22 AM, Gustavo A. R. Silva wrote: > > > Print error message and propagate the return value of > > platform_get_irq on failure. > >You should have probably mentioned that this function no longer

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

Hello! On 6/30/2017 8:22 AM, Gustavo A. R. Silva wrote: Print error message and propagate the return value of platform_get_irq on failure. You should have probably mentioned that this function no longer returns 0 on error. Signed-off-by: Gustavo A. R. Silva

Re: [PATCH] sata_rcar: fix error return code in sata_rcar_probe()

Hello! On 6/30/2017 8:22 AM, Gustavo A. R. Silva wrote: Print error message and propagate the return value of platform_get_irq on failure. You should have probably mentioned that this function no longer returns 0 on error. Signed-off-by: Gustavo A. R. Silva Acked-by: Sergei

[PATCH] sata_rcar: fix error return code in sata_rcar_probe()

Print error message and propagate the return value of platform_get_irq on failure. Signed-off-by: Gustavo A. R. Silva --- drivers/ata/sata_rcar.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c

[PATCH] sata_rcar: fix error return code in sata_rcar_probe()

Print error message and propagate the return value of platform_get_irq on failure. Signed-off-by: Gustavo A. R. Silva --- drivers/ata/sata_rcar.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/ata/sata_rcar.c b/drivers/ata/sata_rcar.c index ee98447..c936b2a