Re: [PATCH] sb1250-duart.c: SB1250 DUART serial support

2007-07-13 Thread Ralf Baechle
On Thu, Jul 12, 2007 at 11:47:12AM -0700, Andrew Morton wrote: > There is no power management support in this driver. There is hardly anything software could do to safe power on Sibyte SOCs. Just like most other MIPS SOCs power managment is mostly left to the hardware which does it by using

Re: [PATCH] sb1250-duart.c: SB1250 DUART serial support

2007-07-13 Thread Maciej W. Rozycki
On Thu, 12 Jul 2007, Andrew Morton wrote: > On Thu, 12 Jul 2007 18:39:00 +0100 (BST) > "Maciej W. Rozycki" <[EMAIL PROTECTED]> wrote: > > > This is a driver for the SB1250 DUART, a dual serial port implementation > > included in the Broadcom family of SOCs descending from the SiByte SB1250 >

Re: [PATCH] sb1250-duart.c: SB1250 DUART serial support

2007-07-13 Thread Ralf Baechle
On Thu, Jul 12, 2007 at 11:47:12AM -0700, Andrew Morton wrote: There is no power management support in this driver. There is hardly anything software could do to safe power on Sibyte SOCs. Just like most other MIPS SOCs power managment is mostly left to the hardware which does it by using

Re: [PATCH] sb1250-duart.c: SB1250 DUART serial support

2007-07-13 Thread Maciej W. Rozycki
On Thu, 12 Jul 2007, Andrew Morton wrote: On Thu, 12 Jul 2007 18:39:00 +0100 (BST) Maciej W. Rozycki [EMAIL PROTECTED] wrote: This is a driver for the SB1250 DUART, a dual serial port implementation included in the Broadcom family of SOCs descending from the SiByte SB1250 MIPS64 chip

Re: [PATCH] sb1250-duart.c: SB1250 DUART serial support

2007-07-12 Thread Andrew Sharp
On Thu, 12 Jul 2007 11:47:12 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Thu, 12 Jul 2007 18:39:00 +0100 (BST) > "Maciej W. Rozycki" <[EMAIL PROTECTED]> wrote: > > > This is a driver for the SB1250 DUART, a dual serial port > > implementation included in the Broadcom family of SOCs

Re: [PATCH] sb1250-duart.c: SB1250 DUART serial support

2007-07-12 Thread Andrew Morton
On Thu, 12 Jul 2007 20:15:11 +0100 Alistair John Strachan <[EMAIL PROTECTED]> wrote: > On Thursday 12 July 2007 19:16:20 Maciej W. Rozycki wrote: > > On Thu, 12 Jul 2007, Andy Whitcroft wrote: > [snip] > > > WARNING: declaring multiple variables together should be avoided > > > #372: FILE:

Re: [PATCH] sb1250-duart.c: SB1250 DUART serial support

2007-07-12 Thread Alistair John Strachan
On Thursday 12 July 2007 19:16:20 Maciej W. Rozycki wrote: > On Thu, 12 Jul 2007, Andy Whitcroft wrote: [snip] > > WARNING: declaring multiple variables together should be avoided > > #372: FILE: drivers/serial/sb1250-duart.c:246: > > + unsigned int mctrl, status; > > Well, this is probably

Re: [PATCH] sb1250-duart.c: SB1250 DUART serial support

2007-07-12 Thread Andrew Morton
On Thu, 12 Jul 2007 18:39:00 +0100 (BST) "Maciej W. Rozycki" <[EMAIL PROTECTED]> wrote: > This is a driver for the SB1250 DUART, a dual serial port implementation > included in the Broadcom family of SOCs descending from the SiByte SB1250 > MIPS64 chip multiprocessor. It is a new

Re: [PATCH] sb1250-duart.c: SB1250 DUART serial support

2007-07-12 Thread Maciej W. Rozycki
On Thu, 12 Jul 2007, Andy Whitcroft wrote: > > printk() should include KERN_ facility level > > #750: FILE: drivers/serial/sb1250-duart.c:675: > > + printk(err); > > Heh, yeah Ingo pointed this style out. This is a wrapper where the > facility will be supplied by the caller (I

Re: [PATCH] sb1250-duart.c: SB1250 DUART serial support

2007-07-12 Thread Ralf Baechle
On Thu, Jul 12, 2007 at 06:39:00PM +0100, Maciej W. Rozycki wrote: > This is a driver for the SB1250 DUART, a dual serial port implementation > included in the Broadcom family of SOCs descending from the SiByte SB1250 > MIPS64 chip multiprocessor. It is a new implementation replacing the >

Re: [PATCH] sb1250-duart.c: SB1250 DUART serial support

2007-07-12 Thread Andy Whitcroft
Maciej W. Rozycki wrote: > This is a driver for the SB1250 DUART, a dual serial port implementation > included in the Broadcom family of SOCs descending from the SiByte SB1250 > MIPS64 chip multiprocessor. It is a new implementation replacing the > old-fashioned driver currently present in

[PATCH] sb1250-duart.c: SB1250 DUART serial support

2007-07-12 Thread Maciej W. Rozycki
This is a driver for the SB1250 DUART, a dual serial port implementation included in the Broadcom family of SOCs descending from the SiByte SB1250 MIPS64 chip multiprocessor. It is a new implementation replacing the old-fashioned driver currently present in the linux-mips.org tree. It

[PATCH] sb1250-duart.c: SB1250 DUART serial support

2007-07-12 Thread Maciej W. Rozycki
This is a driver for the SB1250 DUART, a dual serial port implementation included in the Broadcom family of SOCs descending from the SiByte SB1250 MIPS64 chip multiprocessor. It is a new implementation replacing the old-fashioned driver currently present in the linux-mips.org tree. It

Re: [PATCH] sb1250-duart.c: SB1250 DUART serial support

2007-07-12 Thread Andy Whitcroft
Maciej W. Rozycki wrote: This is a driver for the SB1250 DUART, a dual serial port implementation included in the Broadcom family of SOCs descending from the SiByte SB1250 MIPS64 chip multiprocessor. It is a new implementation replacing the old-fashioned driver currently present in the

Re: [PATCH] sb1250-duart.c: SB1250 DUART serial support

2007-07-12 Thread Ralf Baechle
On Thu, Jul 12, 2007 at 06:39:00PM +0100, Maciej W. Rozycki wrote: This is a driver for the SB1250 DUART, a dual serial port implementation included in the Broadcom family of SOCs descending from the SiByte SB1250 MIPS64 chip multiprocessor. It is a new implementation replacing the

Re: [PATCH] sb1250-duart.c: SB1250 DUART serial support

2007-07-12 Thread Maciej W. Rozycki
On Thu, 12 Jul 2007, Andy Whitcroft wrote: printk() should include KERN_ facility level #750: FILE: drivers/serial/sb1250-duart.c:675: + printk(err); Heh, yeah Ingo pointed this style out. This is a wrapper where the facility will be supplied by the caller (I assume). The

Re: [PATCH] sb1250-duart.c: SB1250 DUART serial support

2007-07-12 Thread Andrew Morton
On Thu, 12 Jul 2007 18:39:00 +0100 (BST) Maciej W. Rozycki [EMAIL PROTECTED] wrote: This is a driver for the SB1250 DUART, a dual serial port implementation included in the Broadcom family of SOCs descending from the SiByte SB1250 MIPS64 chip multiprocessor. It is a new implementation

Re: [PATCH] sb1250-duart.c: SB1250 DUART serial support

2007-07-12 Thread Alistair John Strachan
On Thursday 12 July 2007 19:16:20 Maciej W. Rozycki wrote: On Thu, 12 Jul 2007, Andy Whitcroft wrote: [snip] WARNING: declaring multiple variables together should be avoided #372: FILE: drivers/serial/sb1250-duart.c:246: + unsigned int mctrl, status; Well, this is probably superfluous

Re: [PATCH] sb1250-duart.c: SB1250 DUART serial support

2007-07-12 Thread Andrew Morton
On Thu, 12 Jul 2007 20:15:11 +0100 Alistair John Strachan [EMAIL PROTECTED] wrote: On Thursday 12 July 2007 19:16:20 Maciej W. Rozycki wrote: On Thu, 12 Jul 2007, Andy Whitcroft wrote: [snip] WARNING: declaring multiple variables together should be avoided #372: FILE:

Re: [PATCH] sb1250-duart.c: SB1250 DUART serial support

2007-07-12 Thread Andrew Sharp
On Thu, 12 Jul 2007 11:47:12 -0700 Andrew Morton [EMAIL PROTECTED] wrote: On Thu, 12 Jul 2007 18:39:00 +0100 (BST) Maciej W. Rozycki [EMAIL PROTECTED] wrote: This is a driver for the SB1250 DUART, a dual serial port implementation included in the Broadcom family of SOCs descending from