Re: [PATCH] scanf: convert self-test to KUnit

2025-02-03 Thread Geert Uytterhoeven
On Fri, 31 Jan 2025 at 16:48, Tamir Duberstein wrote: > Convert the scanf() self-test to a KUnit test. > > In the interest of keeping the patch reasonably-sized this doesn't > rename the file in accordance with usual kunit conventions nor does it > refactor the tests into proper parameterized test

Re: [PATCH] scanf: convert self-test to KUnit

2025-02-03 Thread Geert Uytterhoeven
Hi Andy, On Fri, 31 Jan 2025 at 19:06, Andy Shevchenko wrote: > P.S. The test modules in defconfig is something which puzzling me. I would > remove all of them at once, if somebody wants debug configuration, they would > specify it and use with help of merge_config or alike. I really like having

Re: [PATCH] scanf: convert self-test to KUnit

2025-01-31 Thread Tamir Duberstein
On Fri, Jan 31, 2025 at 12:58 PM Tamir Duberstein wrote: > > On Fri, Jan 31, 2025 at 12:50 PM Andy Shevchenko > wrote: > > > > On Fri, Jan 31, 2025 at 12:22:39PM -0500, Tamir Duberstein wrote: > > > On Fri, Jan 31, 2025 at 12:11 PM Andy Shevchenko > > > wrote: > > > > On Fri, Jan 31, 2025 at 10:

Re: [PATCH] scanf: convert self-test to KUnit

2025-01-31 Thread Tamir Duberstein
On Fri, Jan 31, 2025 at 12:50 PM Andy Shevchenko wrote: > > On Fri, Jan 31, 2025 at 12:22:39PM -0500, Tamir Duberstein wrote: > > On Fri, Jan 31, 2025 at 12:11 PM Andy Shevchenko > > wrote: > > > On Fri, Jan 31, 2025 at 10:47:49AM -0500, Tamir Duberstein wrote: [...] > There are other options l

Re: [PATCH] scanf: convert self-test to KUnit

2025-01-31 Thread Andy Shevchenko
On Fri, Jan 31, 2025 at 12:25:20PM -0500, Tamir Duberstein wrote: > On Fri, Jan 31, 2025 at 12:22 PM Tamir Duberstein wrote: > > On Fri, Jan 31, 2025 at 12:11 PM Andy Shevchenko > > wrote: ... > > Can you explain what you mean by using -M -C? The formatting was done > > by hand, is there an aut

Re: [PATCH] scanf: convert self-test to KUnit

2025-01-31 Thread Andy Shevchenko
On Fri, Jan 31, 2025 at 12:22:39PM -0500, Tamir Duberstein wrote: > On Fri, Jan 31, 2025 at 12:11 PM Andy Shevchenko > wrote: > > On Fri, Jan 31, 2025 at 10:47:49AM -0500, Tamir Duberstein wrote: > > > Convert the scanf() self-test to a KUnit test. > > > > > > In the interest of keeping the patch

Re: [PATCH] scanf: convert self-test to KUnit

2025-01-31 Thread Tamir Duberstein
On Fri, Jan 31, 2025 at 12:22 PM Tamir Duberstein wrote: > > On Fri, Jan 31, 2025 at 12:11 PM Andy Shevchenko > wrote: > > > > On Fri, Jan 31, 2025 at 10:47:49AM -0500, Tamir Duberstein wrote: > > > Convert the scanf() self-test to a KUnit test. > > > > > > In the interest of keeping the patch re

Re: [PATCH] scanf: convert self-test to KUnit

2025-01-31 Thread Tamir Duberstein
On Fri, Jan 31, 2025 at 12:11 PM Andy Shevchenko wrote: > > On Fri, Jan 31, 2025 at 10:47:49AM -0500, Tamir Duberstein wrote: > > Convert the scanf() self-test to a KUnit test. > > > > In the interest of keeping the patch reasonably-sized this doesn't > > rename the file in accordance with usual k

Re: [PATCH] scanf: convert self-test to KUnit

2025-01-31 Thread Andy Shevchenko
On Fri, Jan 31, 2025 at 10:47:49AM -0500, Tamir Duberstein wrote: > Convert the scanf() self-test to a KUnit test. > > In the interest of keeping the patch reasonably-sized this doesn't > rename the file in accordance with usual kunit conventions nor does it > refactor the tests into proper parame

[PATCH] scanf: convert self-test to KUnit

2025-01-31 Thread Tamir Duberstein
Convert the scanf() self-test to a KUnit test. In the interest of keeping the patch reasonably-sized this doesn't rename the file in accordance with usual kunit conventions nor does it refactor the tests into proper parameterized tests - it's all one big test case. Signed-off-by: Tamir Duberstein