Re: [PATCH] sched/core: remove unnecessary unlikely() in push_xx_task

2018-11-08 Thread Frank Lee
Hi mingo: What is your point of view? --Yangtao On Sun, Nov 4, 2018 at 1:26 AM Yangtao Li wrote: > > WARN_ON() already contains an unlikely(), so it's not necessary to > use WARN_ON(1). > > Signed-off-by: Yangtao Li > --- > kernel/sched/deadline.c | 4 +--- > kernel/sched/rt.c | 4

Re: [PATCH] sched/core: remove unnecessary unlikely() in push_xx_task

2018-11-08 Thread Frank Lee
Hi mingo: What is your point of view? --Yangtao On Sun, Nov 4, 2018 at 1:26 AM Yangtao Li wrote: > > WARN_ON() already contains an unlikely(), so it's not necessary to > use WARN_ON(1). > > Signed-off-by: Yangtao Li > --- > kernel/sched/deadline.c | 4 +--- > kernel/sched/rt.c | 4

[PATCH] sched/core: remove unnecessary unlikely() in push_xx_task

2018-11-03 Thread Yangtao Li
WARN_ON() already contains an unlikely(), so it's not necessary to use WARN_ON(1). Signed-off-by: Yangtao Li --- kernel/sched/deadline.c | 4 +--- kernel/sched/rt.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c

[PATCH] sched/core: remove unnecessary unlikely() in push_xx_task

2018-11-03 Thread Yangtao Li
WARN_ON() already contains an unlikely(), so it's not necessary to use WARN_ON(1). Signed-off-by: Yangtao Li --- kernel/sched/deadline.c | 4 +--- kernel/sched/rt.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c