Re: [PATCH] sched/cpufreq: Align trace event behavior of fast switching

2019-08-28 Thread Rafael J. Wysocki
On Monday, August 26, 2019 11:40:58 AM CEST Peter Zijlstra wrote: > On Mon, Aug 26, 2019 at 11:10:52AM +0200, Rafael J. Wysocki wrote: > > On Wednesday, August 7, 2019 5:33:40 PM CEST Douglas RAILLARD wrote: > > > Fast switching path only emits an event for the CPU of interest, whereas > > > the >

Re: [PATCH] sched/cpufreq: Align trace event behavior of fast switching

2019-08-26 Thread Dietmar Eggemann
On 26/08/2019 13:24, Peter Zijlstra wrote: > On Mon, Aug 26, 2019 at 11:51:17AM +0200, Dietmar Eggemann wrote: > >> Not sure about the extra 'if trace_cpu_frequency_enabled()' but I guess >> it doesn't hurt. > > Without that you do that for_each_cpu() iteration unconditionally, even > if the tra

Re: [PATCH] sched/cpufreq: Align trace event behavior of fast switching

2019-08-26 Thread Peter Zijlstra
On Mon, Aug 26, 2019 at 11:51:17AM +0200, Dietmar Eggemann wrote: > Not sure about the extra 'if trace_cpu_frequency_enabled()' but I guess > it doesn't hurt. Without that you do that for_each_cpu() iteration unconditionally, even if the tracepoint is disabled.

Re: [PATCH] sched/cpufreq: Align trace event behavior of fast switching

2019-08-26 Thread Dietmar Eggemann
On 26/08/2019 11:40, Peter Zijlstra wrote: > On Mon, Aug 26, 2019 at 11:10:52AM +0200, Rafael J. Wysocki wrote: >> On Wednesday, August 7, 2019 5:33:40 PM CEST Douglas RAILLARD wrote: >>> Fast switching path only emits an event for the CPU of interest, whereas the >>> regular path emits an event fo

Re: [PATCH] sched/cpufreq: Align trace event behavior of fast switching

2019-08-26 Thread Peter Zijlstra
On Mon, Aug 26, 2019 at 11:10:52AM +0200, Rafael J. Wysocki wrote: > On Wednesday, August 7, 2019 5:33:40 PM CEST Douglas RAILLARD wrote: > > Fast switching path only emits an event for the CPU of interest, whereas the > > regular path emits an event for all the CPUs that had their frequency > > c

Re: [PATCH] sched/cpufreq: Align trace event behavior of fast switching

2019-08-26 Thread Rafael J. Wysocki
On Wednesday, August 7, 2019 5:33:40 PM CEST Douglas RAILLARD wrote: > Fast switching path only emits an event for the CPU of interest, whereas the > regular path emits an event for all the CPUs that had their frequency changed, > i.e. all the CPUs sharing the same policy. > > With the current beh

Re: [PATCH] sched/cpufreq: Align trace event behavior of fast switching

2019-08-08 Thread Douglas Raillard
Hi Rafael, On 8/7/19 9:40 PM, Rafael J. Wysocki wrote: On Wed, Aug 7, 2019 at 5:34 PM Douglas RAILLARD wrote: Fast switching path only emits an event for the CPU of interest, whereas the regular path emits an event for all the CPUs that had their frequency changed, i.e. all the CPUs sharing t

Re: [PATCH] sched/cpufreq: Align trace event behavior of fast switching

2019-08-07 Thread Rafael J. Wysocki
On Wed, Aug 7, 2019 at 5:34 PM Douglas RAILLARD wrote: > > Fast switching path only emits an event for the CPU of interest, whereas the > regular path emits an event for all the CPUs that had their frequency changed, > i.e. all the CPUs sharing the same policy. > > With the current behavior, looki

[PATCH] sched/cpufreq: Align trace event behavior of fast switching

2019-08-07 Thread Douglas RAILLARD
Fast switching path only emits an event for the CPU of interest, whereas the regular path emits an event for all the CPUs that had their frequency changed, i.e. all the CPUs sharing the same policy. With the current behavior, looking at cpu_frequency event for a given CPU that is using the fast sw