[PATCH] sched/fair: Fix fixed point arithmetic width for shares and effective load

2016-08-22 Thread Dietmar Eggemann
Since commit 2159197d6677 ("sched/core: Enable increased load resolution on 64-bit kernels") we now have two different fixed point units for load. shares in calc_cfs_shares() has 20 bit fixed point unit on 64-bit kernels. Therefore use scale_load() on MIN_SHARES. wl in effective_load() has 10 bit f

Re: [PATCH] sched/fair: Fix fixed point arithmetic width for shares and effective load

2016-08-23 Thread Peter Zijlstra
On Tue, Aug 23, 2016 at 01:40:01PM -0700, Paul Turner wrote: > Independent of this patch: > When we initially introduced load scaling, it was ~uniform on every > value. Most of the current pain has come from, and will continue to > come from, that with v2 of the load-tracking this is no longer t

Re: [PATCH] sched/fair: Fix fixed point arithmetic width for shares and effective load

2016-08-23 Thread Paul Turner
On Mon, Aug 22, 2016 at 7:00 AM, Dietmar Eggemann wrote: > > Since commit 2159197d6677 ("sched/core: Enable increased load resolution > on 64-bit kernels") we now have two different fixed point units for > load. > shares in calc_cfs_shares() has 20 bit fixed point unit on 64-bit > kernels. Therefo

Re: [PATCH] sched/fair: Fix fixed point arithmetic width for shares and effective load

2016-08-24 Thread Dietmar Eggemann
On 23/08/16 21:40, Paul Turner wrote: > On Mon, Aug 22, 2016 at 7:00 AM, Dietmar Eggemann [...] >> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c >> index 61d485421bed..18f80c4c7737 100644 >> --- a/kernel/sched/fair.c >> +++ b/kernel/sched/fair.c >> @@ -2530,8 +2530,8 @@ static long calc_