Re: [PATCH] sched/fair: Invoke cpufreq hooks for CONFIG_SMP unset

2016-05-10 Thread Ingo Molnar
* Rafael J. Wysocki wrote: > On Monday, May 09, 2016 04:53:16 PM Steve Muckle wrote: > > On Sat, May 07, 2016 at 08:30:51AM +0200, Ingo Molnar wrote: > > > > > > * Peter Zijlstra wrote: > > > > > > > On Fri, May 06, 2016 at 02:58:43PM +0200, Rafael J. Wysocki wrote: > > > > > From: Rafael J.

Re: [PATCH] sched/fair: Invoke cpufreq hooks for CONFIG_SMP unset

2016-05-09 Thread Rafael J. Wysocki
On Monday, May 09, 2016 04:53:16 PM Steve Muckle wrote: > On Sat, May 07, 2016 at 08:30:51AM +0200, Ingo Molnar wrote: > > > > * Peter Zijlstra wrote: > > > > > On Fri, May 06, 2016 at 02:58:43PM +0200, Rafael J. Wysocki wrote: > > > > From: Rafael J. Wysocki > > > > > > > > Commit 34e2c555f3e

Re: [PATCH] sched/fair: Invoke cpufreq hooks for CONFIG_SMP unset

2016-05-09 Thread Steve Muckle
On Sat, May 07, 2016 at 08:30:51AM +0200, Ingo Molnar wrote: > > * Peter Zijlstra wrote: > > > On Fri, May 06, 2016 at 02:58:43PM +0200, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > Commit 34e2c555f3e1 (cpufreq: Add mechanism for registering utilization > > > update callb

Re: [PATCH] sched/fair: Invoke cpufreq hooks for CONFIG_SMP unset

2016-05-09 Thread Peter Zijlstra
On Sat, May 07, 2016 at 08:30:51AM +0200, Ingo Molnar wrote: > * Peter Zijlstra wrote: > > Rafael; feel free to push this through the pm tree. > > > > Acked-by: Peter Zijlstra (Intel) > > I already have it in sched/urgent. Ah, indeed you did, I must've missed that, thanks!

Re: [PATCH] sched/fair: Invoke cpufreq hooks for CONFIG_SMP unset

2016-05-06 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Fri, May 06, 2016 at 02:58:43PM +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Commit 34e2c555f3e1 (cpufreq: Add mechanism for registering utilization > > update callbacks) overlooked the fact that update_load_avg(), where > > CFS invokes cpufr

Re: [PATCH] sched/fair: Invoke cpufreq hooks for CONFIG_SMP unset

2016-05-06 Thread Peter Zijlstra
On Fri, May 06, 2016 at 02:58:43PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Commit 34e2c555f3e1 (cpufreq: Add mechanism for registering utilization > update callbacks) overlooked the fact that update_load_avg(), where > CFS invokes cpufreq utilization update hooks, becomes an

Re: [PATCH] sched/fair: Invoke cpufreq hooks for CONFIG_SMP unset

2016-05-06 Thread Rafael J. Wysocki
On Friday, May 06, 2016 12:08:25 PM Steve Muckle wrote: > Looks good to me. > > Also re-tested with intel_pstate on i7-3630QM !SMP, confirmed issue > is resolved. Thanks!

Re: [PATCH] sched/fair: Invoke cpufreq hooks for CONFIG_SMP unset

2016-05-06 Thread Steve Muckle
Looks good to me. Also re-tested with intel_pstate on i7-3630QM !SMP, confirmed issue is resolved. I didn't retest with ondemand because for some reason that wasn't showing the problem before.

[PATCH] sched/fair: Invoke cpufreq hooks for CONFIG_SMP unset

2016-05-06 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Commit 34e2c555f3e1 (cpufreq: Add mechanism for registering utilization update callbacks) overlooked the fact that update_load_avg(), where CFS invokes cpufreq utilization update hooks, becomes an empty stub for CONFIG_SMP unset. In consequence, if CONFIG_SMP is not set,