Re: [PATCH] sched/fair: Restore env status before goto redo in load_balance()

2015-03-31 Thread Xunlei Pang
On 27 March 2015 at 23:30, Peter Zijlstra wrote: > On Wed, Mar 18, 2015 at 02:31:02PM +0800, Xunlei Pang wrote: >> From: Xunlei Pang >> >> In load_balance(), some members of lb_env will be assigned with >> new values in LBF_DST_PINNED case. But lb_env::flags may still >> retain LBF_ALL_PINNED if

Re: [PATCH] sched/fair: Restore env status before goto redo in load_balance()

2015-03-31 Thread Xunlei Pang
On 27 March 2015 at 23:30, Peter Zijlstra pet...@infradead.org wrote: On Wed, Mar 18, 2015 at 02:31:02PM +0800, Xunlei Pang wrote: From: Xunlei Pang pang.xun...@linaro.org In load_balance(), some members of lb_env will be assigned with new values in LBF_DST_PINNED case. But lb_env::flags may

Re: [PATCH] sched/fair: Restore env status before goto redo in load_balance()

2015-03-27 Thread Peter Zijlstra
On Wed, Mar 18, 2015 at 02:31:02PM +0800, Xunlei Pang wrote: > From: Xunlei Pang > > In load_balance(), some members of lb_env will be assigned with > new values in LBF_DST_PINNED case. But lb_env::flags may still > retain LBF_ALL_PINNED if no proper tasks were found afterwards > due to another

Re: [PATCH] sched/fair: Restore env status before goto redo in load_balance()

2015-03-27 Thread Xunlei Pang
Ping Peter > From: Xunlei Pang > > In load_balance(), some members of lb_env will be assigned with > new values in LBF_DST_PINNED case. But lb_env::flags may still > retain LBF_ALL_PINNED if no proper tasks were found afterwards > due to another balance, task affinity changing, etc, which can >

Re: [PATCH] sched/fair: Restore env status before goto redo in load_balance()

2015-03-27 Thread Xunlei Pang
Ping Peter From: Xunlei Pang pang.xun...@linaro.org In load_balance(), some members of lb_env will be assigned with new values in LBF_DST_PINNED case. But lb_env::flags may still retain LBF_ALL_PINNED if no proper tasks were found afterwards due to another balance, task affinity changing,

Re: [PATCH] sched/fair: Restore env status before goto redo in load_balance()

2015-03-27 Thread Peter Zijlstra
On Wed, Mar 18, 2015 at 02:31:02PM +0800, Xunlei Pang wrote: From: Xunlei Pang pang.xun...@linaro.org In load_balance(), some members of lb_env will be assigned with new values in LBF_DST_PINNED case. But lb_env::flags may still retain LBF_ALL_PINNED if no proper tasks were found afterwards

[PATCH] sched/fair: Restore env status before goto redo in load_balance()

2015-03-18 Thread Xunlei Pang
From: Xunlei Pang In load_balance(), some members of lb_env will be assigned with new values in LBF_DST_PINNED case. But lb_env::flags may still retain LBF_ALL_PINNED if no proper tasks were found afterwards due to another balance, task affinity changing, etc, which can really happen because

[PATCH] sched/fair: Restore env status before goto redo in load_balance()

2015-03-18 Thread Xunlei Pang
From: Xunlei Pang pang.xun...@linaro.org In load_balance(), some members of lb_env will be assigned with new values in LBF_DST_PINNED case. But lb_env::flags may still retain LBF_ALL_PINNED if no proper tasks were found afterwards due to another balance, task affinity changing, etc, which can