Re: [PATCH] sched/fair: Update rq_clock, cfs_rq before migrating for asym cpu capacity

2019-07-09 Thread Vincent Guittot
On Tue, 9 Jul 2019 at 17:42, Chris Redpath wrote: > > On 09/07/2019 16:36, Vincent Guittot wrote: > > Hi Chris, > > > >> > >> We enter this code quite often in our testing, most individual runs of a > >> test which has small tasks involved have at least one hit where we make > >> a change to the c

Re: [PATCH] sched/fair: Update rq_clock, cfs_rq before migrating for asym cpu capacity

2019-07-09 Thread Chris Redpath
On 09/07/2019 16:36, Vincent Guittot wrote: Hi Chris, We enter this code quite often in our testing, most individual runs of a test which has small tasks involved have at least one hit where we make a change to the clock with this patch in. Do you have a rt-app file that you can share ? T

Re: [PATCH] sched/fair: Update rq_clock, cfs_rq before migrating for asym cpu capacity

2019-07-09 Thread Vincent Guittot
Hi Chris, On Tue, 9 Jul 2019 at 17:23, Chris Redpath wrote: > > Hi Peter, > > On 09/07/2019 14:50, Peter Zijlstra wrote: > > On Tue, Jul 09, 2019 at 12:57:59PM +0100, Chris Redpath wrote: > >> The ancient workaround to avoid the cost of updating rq clocks in the > >> middle of a migration causes

Re: [PATCH] sched/fair: Update rq_clock, cfs_rq before migrating for asym cpu capacity

2019-07-09 Thread Chris Redpath
Hi Peter, On 09/07/2019 14:50, Peter Zijlstra wrote: > On Tue, Jul 09, 2019 at 12:57:59PM +0100, Chris Redpath wrote: >> The ancient workaround to avoid the cost of updating rq clocks in the >> middle of a migration causes some issues on asymmetric CPU capacity >> systems where we use task utiliza

Re: [PATCH] sched/fair: Update rq_clock, cfs_rq before migrating for asym cpu capacity

2019-07-09 Thread Peter Zijlstra
On Tue, Jul 09, 2019 at 12:57:59PM +0100, Chris Redpath wrote: > The ancient workaround to avoid the cost of updating rq clocks in the > middle of a migration causes some issues on asymmetric CPU capacity > systems where we use task utilization to determine which cpus fit a task. > On quiet systems

[PATCH] sched/fair: Update rq_clock, cfs_rq before migrating for asym cpu capacity

2019-07-09 Thread Chris Redpath
The ancient workaround to avoid the cost of updating rq clocks in the middle of a migration causes some issues on asymmetric CPU capacity systems where we use task utilization to determine which cpus fit a task. On quiet systems we can inflate task util after a migration which causes misfit to fire