Re: [PATCH] sched/fair: fix variable "done" set but not used

On 27/05/2019 01:53, Qian Cai wrote: [...] >> For some reason I can't get this warning to fire on my end (arm64 defconfig >> + all the NO_HZ stuff set to nope + GCC 8.1). However I do think there are >> things we could improve here. > > I like your approach more if it works. The warning can be rep

Re: [PATCH] sched/fair: fix variable "done" set but not used

> On May 26, 2019, at 7:56 PM, Valentin Schneider > wrote: > > Hi, > > On 25/05/2019 17:18, Qian Cai wrote: >> The commit f643ea220701 ("sched/nohz: Stop NOHZ stats when decayed") >> introduced a compilation warning if CONFIG_NO_HZ_COMMON=n, >> >> kernel/sched/fair.c: In function 'update_bl

Re: [PATCH] sched/fair: fix variable "done" set but not used

Hi, On 25/05/2019 17:18, Qian Cai wrote: > The commit f643ea220701 ("sched/nohz: Stop NOHZ stats when decayed") > introduced a compilation warning if CONFIG_NO_HZ_COMMON=n, > > kernel/sched/fair.c: In function 'update_blocked_averages': > kernel/sched/fair.c:7750:7: warning: variable 'done' set b

[PATCH] sched/fair: fix variable "done" set but not used

The commit f643ea220701 ("sched/nohz: Stop NOHZ stats when decayed") introduced a compilation warning if CONFIG_NO_HZ_COMMON=n, kernel/sched/fair.c: In function 'update_blocked_averages': kernel/sched/fair.c:7750:7: warning: variable 'done' set but not used [-Wunused-but-set-variable] Fix it by a