Re: [PATCH] sched/fair: update_pick_idlest() Select group with lowest group_util when idle_cpus are equal

2020-07-02 Thread Vincent Guittot
On Thu, 2 Jul 2020 at 15:29, Mel Gorman wrote: > > On Thu, Jul 02, 2020 at 11:27:52AM +0200, Dietmar Eggemann wrote: > > On 17/06/2020 16:52, Peter Puhov wrote: > > > On Wed, 17 Jun 2020 at 06:50, Valentin Schneider > > > wrote: > > >> > > >> > > >> On 16/06/20 17:48, peter.pu...@linaro.org wrote

Re: [PATCH] sched/fair: update_pick_idlest() Select group with lowest group_util when idle_cpus are equal

2020-07-02 Thread Mel Gorman
On Thu, Jul 02, 2020 at 11:27:52AM +0200, Dietmar Eggemann wrote: > On 17/06/2020 16:52, Peter Puhov wrote: > > On Wed, 17 Jun 2020 at 06:50, Valentin Schneider > > wrote: > >> > >> > >> On 16/06/20 17:48, peter.pu...@linaro.org wrote: > >>> From: Peter Puhov > >>> We tested this patch with follo

Re: [PATCH] sched/fair: update_pick_idlest() Select group with lowest group_util when idle_cpus are equal

2020-07-02 Thread Dietmar Eggemann
On 17/06/2020 16:52, Peter Puhov wrote: > On Wed, 17 Jun 2020 at 06:50, Valentin Schneider > wrote: >> >> >> On 16/06/20 17:48, peter.pu...@linaro.org wrote: >>> From: Peter Puhov >>> We tested this patch with following benchmarks: >>> perf bench -f simple sched pipe -l 400 >>> perf bench

Re: [PATCH] sched/fair: update_pick_idlest() Select group with lowest group_util when idle_cpus are equal

2020-06-17 Thread Peter Puhov
On Wed, 17 Jun 2020 at 06:50, Valentin Schneider wrote: > > > On 16/06/20 17:48, peter.pu...@linaro.org wrote: > > From: Peter Puhov > > We tested this patch with following benchmarks: > > perf bench -f simple sched pipe -l 400 > > perf bench -f simple sched messaging -l 3 > > perf

Re: [PATCH] sched/fair: update_pick_idlest() Select group with lowest group_util when idle_cpus are equal

2020-06-17 Thread Valentin Schneider
On 16/06/20 17:48, peter.pu...@linaro.org wrote: > From: Peter Puhov > We tested this patch with following benchmarks: > perf bench -f simple sched pipe -l 400 > perf bench -f simple sched messaging -l 3 > perf bench -f simple mem memset -s 3GB -l 15 -f default > perf bench -f s

[PATCH] sched/fair: update_pick_idlest() Select group with lowest group_util when idle_cpus are equal

2020-06-16 Thread peter . puhov
From: Peter Puhov In slow path, when selecting idlest group, if both groups have type group_has_spare, only idle_cpus count gets compared. As a result, if multiple tasks are created in a tight loop, and go back to sleep immediately (while waiting for all tasks to be created), they may be sched