Re: [PATCH] sched/fair: use signed long when compute energy delta in eas

2021-04-13 Thread Xuewen Yan
Hi > > > > > > In fair.c:select_task_rq_fair(), if feec() returns a error (< 0), then > > > prev_cpu is selected. I think it's better to still let feec() signal > > > that something happened and let select_task_rq_fair() select prev_cpu by > > > itself. > > In fair.c:select_task_rq_fair(), when fee

Re: [PATCH] sched/fair: use signed long when compute energy delta in eas

2021-04-13 Thread Pierre Gondois
Hi, > > In fair.c:select_task_rq_fair(), if feec() returns a error (< 0), then > prev_cpu is selected. I think it's better to still let feec() signal > that something happened and let select_task_rq_fair() select prev_cpu by > itself. In fair.c:select_task_rq_fair(), when feec() returns a error (

Re: [PATCH] sched/fair: use signed long when compute energy delta in eas

2021-04-12 Thread Xuewen Yan
Hi On Tue, Apr 13, 2021 at 1:15 AM Pierre Gondois wrote: > > Hi > > > > > > > > > > This patch-set is not significantly improving the execution time of > > > > > feec(). The results we have so far are an improvement of 5-10% in > > > > > execution time, with feec() being executed in < 10us. So th

Re: [PATCH] sched/fair: use signed long when compute energy delta in eas

2021-04-12 Thread Pierre Gondois
Hi > > > > > > This patch-set is not significantly improving the execution time of > > > feec(). The results we have so far are an improvement of 5-10% in > > > execution time, with feec() being executed in < 10us. So the gain is not > > > spectacular. > > > > well, I meaned to cache all util v

Re: [PATCH] sched/fair: use signed long when compute energy delta in eas

2021-04-12 Thread Xuewen Yan
Hi > > Hi, > > > > > > This patch-set is not significantly improving the execution time of > > > feec(). The results we have so far are an improvement of 5-10% in > > > execution time, with feec() being executed in < 10us. So the gain is not > > > spectacular. > > > > well, I meaned to cache all ut

Re: [PATCH] sched/fair: use signed long when compute energy delta in eas

2021-04-12 Thread Pierre Gondois
Hi, > > > Hi, > > > > I test the patch, but the overflow still exists. > > > > In the "sched/fair: Use pd_cache to speed up > > find_energy_efficient_cpu()" > > > > I wonder why recompute the cpu util when cpu==dst_cpu in > > compute_energy(), > > > > when the dst_cpu's util change, it also would

Re: [PATCH] sched/fair: use signed long when compute energy delta in eas

2021-04-08 Thread Xuewen Yan
Hi > > Hi, > > Hi > > > > On Wed, Apr 7, 2021 at 10:11 PM Pierre wrote: > > > > > > Hi, > > > > I test the patch, but the overflow still exists. > > > > In the "sched/fair: Use pd_cache to speed up > > find_energy_efficient_cpu()" > > > > I wonder why recompute the cpu util when cpu==dst_cpu in >

Re: [PATCH] sched/fair: use signed long when compute energy delta in eas

2021-04-08 Thread Pierre
Hi, Hi On Wed, Apr 7, 2021 at 10:11 PM Pierre wrote: > > Hi, > > I test the patch, but the overflow still exists. > > In the "sched/fair: Use pd_cache to speed up find_energy_efficient_cpu()" > > I wonder why recompute the cpu util when cpu==dst_cpu in compute_energy(), > > when the dst_cpu'

Re: [PATCH] sched/fair: use signed long when compute energy delta in eas

2021-04-07 Thread Xuewen Yan
Hi On Wed, Apr 7, 2021 at 10:11 PM Pierre wrote: > > Hi, > > I test the patch, but the overflow still exists. > > In the "sched/fair: Use pd_cache to speed up find_energy_efficient_cpu()" > > I wonder why recompute the cpu util when cpu==dst_cpu in compute_energy(), > > when the dst_cpu's util ch

Re: [PATCH] sched/fair: use signed long when compute energy delta in eas

2021-04-07 Thread Pierre
Hi, I test the patch, but the overflow still exists. In the "sched/fair: Use pd_cache to speed up find_energy_efficient_cpu()" I wonder why recompute the cpu util when cpu==dst_cpu in compute_energy(), when the dst_cpu's util change, it also would cause the overflow. The patches aim to cache th

Re: [PATCH] sched/fair: use signed long when compute energy delta in eas

2021-04-06 Thread Xuewen Yan
Hi Dietmar On Fri, Apr 2, 2021 at 2:07 AM Dietmar Eggemann wrote: > > +cc: Pierre Gondois > > On 30/03/2021 11:45, Quentin Perret wrote: > > Hi, > > > > On Tuesday 30 Mar 2021 at 13:21:54 (+0800), Xuewen Yan wrote: > >> From: Xuewen Yan > >> > >> now the energy delta compute as follow: > >> > >

Re: [PATCH] sched/fair: use signed long when compute energy delta in eas

2021-04-01 Thread Dietmar Eggemann
+cc: Pierre Gondois On 30/03/2021 11:45, Quentin Perret wrote: > Hi, > > On Tuesday 30 Mar 2021 at 13:21:54 (+0800), Xuewen Yan wrote: >> From: Xuewen Yan >> >> now the energy delta compute as follow: >> >> base_energy_pd = compute_energy(p, -1, pd); >> --->Traverse all CPUs in pd >>

Re: [PATCH] sched/fair: use signed long when compute energy delta in eas

2021-03-30 Thread Quentin Perret
Hi, On Tuesday 30 Mar 2021 at 13:21:54 (+0800), Xuewen Yan wrote: > From: Xuewen Yan > > now the energy delta compute as follow: > > base_energy_pd = compute_energy(p, -1, pd); > --->Traverse all CPUs in pd > --->em_pd_energy() > -

[PATCH] sched/fair: use signed long when compute energy delta in eas

2021-03-29 Thread Xuewen Yan
From: Xuewen Yan now the energy delta compute as follow: base_energy_pd = compute_energy(p, -1, pd); --->Traverse all CPUs in pd --->em_pd_energy() - \ search for the max_sapre_cap_cpu \ ---