dhat.com; pet...@infradead.org;
>> juri.le...@redhat.com; dietmar.eggem...@arm.com; rost...@goodmis.org;
>> bseg...@google.com; mgor...@suse.de
>> Cc: linux-kernel@vger.kernel.org; linux...@openeuler.org; Song Bao Hua (Barry
>> Song)
>> Subject: Re: [PATCH] sched/topology:
m...@arm.com; rost...@goodmis.org;
> bseg...@google.com; mgor...@suse.de
> Cc: linux-kernel@vger.kernel.org; linux...@openeuler.org; Song Bao Hua (Barry
> Song)
> Subject: Re: [PATCH] sched/topology: remove redundant cpumask_and in
> init_overlap_sched_group
>
> On 05/03/21 11:
On 05/03/21 11:29, Barry Song wrote:
> mask is built in build_balance_mask() by for_each_cpu(i, sg_span), so
> it must be a subset of sched_group_span(sg).
So we should indeed have
cpumask_subset(sched_group_span(sg), mask)
but that doesn't imply
cpumask_first(sched_group_span(sg)) == cpuma
mask is built in build_balance_mask() by for_each_cpu(i, sg_span), so
it must be a subset of sched_group_span(sg). Though cpumask_first_and
doesn't lead to a wrong result of balance cpu, it is pointless to do
cpumask_and again.
Signed-off-by: Barry Song
---
kernel/sched/topology.c | 2 +-
1 file
4 matches
Mail list logo