Re: [PATCH] sched: fix sched_entity avg statistics update

2014-01-22 Thread Chris Redpath
On 21/01/14 16:12, Vincent Guittot wrote: With the current implementation, the load average statistics of a sched entity change according to other activity on the CPU even if this activity is done between the running window of the sched entity and have no influence on the running duration of the

Re: [PATCH] sched: fix sched_entity avg statistics update

2014-01-22 Thread Chris Redpath
On 21/01/14 16:12, Vincent Guittot wrote: With the current implementation, the load average statistics of a sched entity change according to other activity on the CPU even if this activity is done between the running window of the sched entity and have no influence on the running duration of the

Re: [PATCH] sched: fix sched_entity avg statistics update

2014-01-21 Thread Peter Zijlstra
On Tue, Jan 21, 2014 at 12:31:18PM -0800, Paul Turner wrote: > I think I need to go through and do a comments patch like we did with > the wake-affine math; it's too easy to make a finicky mistake like > this when not touching this path for a while. If you're going to do that, please consider

Re: [PATCH] sched: fix sched_entity avg statistics update

2014-01-21 Thread Paul Turner
On Tue, Jan 21, 2014 at 12:00 PM, Vincent Guittot wrote: > > Le 21 janv. 2014 19:39, a écrit : > > >> >> Vincent Guittot writes: >> >> > With the current implementation, the load average statistics of a sched >> > entity >> > change according to other activity on the CPU even if this activity

Re: [PATCH] sched: fix sched_entity avg statistics update

2014-01-21 Thread Vincent Guittot
On 21 January 2014 19:38, wrote: > Vincent Guittot writes: > >> With the current implementation, the load average statistics of a sched >> entity >> change according to other activity on the CPU even if this activity is done >> between the running window of the sched entity and have no

Re: [PATCH] sched: fix sched_entity avg statistics update

2014-01-21 Thread bsegall
Vincent Guittot writes: > With the current implementation, the load average statistics of a sched entity > change according to other activity on the CPU even if this activity is done > between the running window of the sched entity and have no influence on the > running duration of the task. > >

[PATCH] sched: fix sched_entity avg statistics update

2014-01-21 Thread Vincent Guittot
With the current implementation, the load average statistics of a sched entity change according to other activity on the CPU even if this activity is done between the running window of the sched entity and have no influence on the running duration of the task. When a task wakes up on the same

[PATCH] sched: fix sched_entity avg statistics update

2014-01-21 Thread Vincent Guittot
With the current implementation, the load average statistics of a sched entity change according to other activity on the CPU even if this activity is done between the running window of the sched entity and have no influence on the running duration of the task. When a task wakes up on the same

Re: [PATCH] sched: fix sched_entity avg statistics update

2014-01-21 Thread bsegall
Vincent Guittot vincent.guit...@linaro.org writes: With the current implementation, the load average statistics of a sched entity change according to other activity on the CPU even if this activity is done between the running window of the sched entity and have no influence on the running

Re: [PATCH] sched: fix sched_entity avg statistics update

2014-01-21 Thread Vincent Guittot
On 21 January 2014 19:38, bseg...@google.com wrote: Vincent Guittot vincent.guit...@linaro.org writes: With the current implementation, the load average statistics of a sched entity change according to other activity on the CPU even if this activity is done between the running window of

Re: [PATCH] sched: fix sched_entity avg statistics update

2014-01-21 Thread Paul Turner
On Tue, Jan 21, 2014 at 12:00 PM, Vincent Guittot vincent.guit...@linaro.org wrote: Le 21 janv. 2014 19:39, bseg...@google.com a écrit : Vincent Guittot vincent.guit...@linaro.org writes: With the current implementation, the load average statistics of a sched entity change according

Re: [PATCH] sched: fix sched_entity avg statistics update

2014-01-21 Thread Peter Zijlstra
On Tue, Jan 21, 2014 at 12:31:18PM -0800, Paul Turner wrote: I think I need to go through and do a comments patch like we did with the wake-affine math; it's too easy to make a finicky mistake like this when not touching this path for a while. If you're going to do that, please consider fixing