Re: [PATCH] sched: reset sysctl_sched_time_avg to default when

2017-09-04 Thread Ethan Zhao
Peter, On 2017/9/4 15:32, Peter Zijlstra wrote: On Sat, Sep 02, 2017 at 08:33:03AM +0800, Ethan Zhao wrote: Yep, that is the first place I considered to set the limit, but that would break KABI ? nah..   V4 sent, please ignore v2 & v3.   Thanks,   Ethan

Re: [PATCH] sched: reset sysctl_sched_time_avg to default when

2017-09-04 Thread Peter Zijlstra
On Sat, Sep 02, 2017 at 08:33:03AM +0800, Ethan Zhao wrote: > Yep, that is the first place I considered to set the limit, but that would > break KABI ? nah..

Re: [PATCH] sched: reset sysctl_sched_time_avg to default when

2017-09-01 Thread Ethan Zhao
Peter, V2 sent, tested okay on stable 4.1, re-factor a little, could apply to v4.13-rc5, please review. [root@ ~]# sysctl kernel.sched_time_avg_ms kernel.sched_time_avg_ms = 1000 [root@ ~]# sysctl kernel.sched_time_avg_ms=0 sysctl: setting key "kernel.sched_time_avg_ms": Invalid argument kernel.

Re: [PATCH] sched: reset sysctl_sched_time_avg to default when

2017-09-01 Thread Ethan Zhao
Yep, that is the first place I considered to set the limit, but that would break KABI ? Thanks, Ethan On Fri, Sep 1, 2017 at 8:32 PM, Peter Zijlstra wrote: > On Fri, Sep 01, 2017 at 07:31:54PM +0800, Ethan Zhao wrote: >> System will hang if user set sysctl_sched_time_avg to 0 by >> >> [root@XXX

Re: [PATCH] sched: reset sysctl_sched_time_avg to default when

2017-09-01 Thread Peter Zijlstra
On Fri, Sep 01, 2017 at 07:31:54PM +0800, Ethan Zhao wrote: > System will hang if user set sysctl_sched_time_avg to 0 by > > [root@XXX ~]# sysctl kernel.sched_time_avg_ms=0 > > Stack traceback for pid 0 > 0x883f6406c600 0 0 1 3 R 0x883f6406cf50 *swapper/3 > 883f7ccc3ae8 00

[PATCH] sched: reset sysctl_sched_time_avg to default when

2017-09-01 Thread Ethan Zhao
System will hang if user set sysctl_sched_time_avg to 0 by [root@XXX ~]# sysctl kernel.sched_time_avg_ms=0 Stack traceback for pid 0 0x883f6406c600 0 0 1 3 R 0x883f6406cf50 *swapper/3 883f7ccc3ae8 0018 810c4dd0 00017800 883f7ccc3d78 000