Re: [PATCH] sched.h: drop in_ubsan field when UBSAN is in trap mode

2020-09-11 Thread Jann Horn
On Fri, Sep 11, 2020 at 5:15 PM Elena Petrova wrote: > On Thu, 10 Sep 2020 at 20:35, Jann Horn wrote: > > On Thu, Sep 10, 2020 at 3:48 PM Elena Petrova wrote: > > > in_ubsan field of task_struct is only used in lib/ubsan.c, which in its > > > turn is used only `ifneq ($(CONFIG_UBSAN_TRAP),y)`. >

Re: [PATCH] sched.h: drop in_ubsan field when UBSAN is in trap mode

2020-09-11 Thread Elena Petrova
Hi Jann, On Thu, 10 Sep 2020 at 20:35, Jann Horn wrote: > > On Thu, Sep 10, 2020 at 3:48 PM Elena Petrova wrote: > > in_ubsan field of task_struct is only used in lib/ubsan.c, which in its > > turn is used only `ifneq ($(CONFIG_UBSAN_TRAP),y)`. > > > > Removing unnecessary field from a task_stru

[PATCH] sched.h: drop in_ubsan field when UBSAN is in trap mode

2020-09-10 Thread Elena Petrova
in_ubsan field of task_struct is only used in lib/ubsan.c, which in its turn is used only `ifneq ($(CONFIG_UBSAN_TRAP),y)`. Removing unnecessary field from a task_struct will help preserve the ABI between vanilla and CONFIG_UBSAN_TRAP'ed kernels. In particular, this will help enabling bounds sanit

Re: [PATCH] sched.h: drop in_ubsan field when UBSAN is in trap mode

2020-09-10 Thread Jann Horn
On Thu, Sep 10, 2020 at 3:48 PM Elena Petrova wrote: > in_ubsan field of task_struct is only used in lib/ubsan.c, which in its > turn is used only `ifneq ($(CONFIG_UBSAN_TRAP),y)`. > > Removing unnecessary field from a task_struct will help preserve the > ABI between vanilla and CONFIG_UBSAN_TRAP'

Re: [PATCH] sched.h: drop in_ubsan field when UBSAN is in trap mode

2020-09-10 Thread Kees Cook
On Thu, Sep 10, 2020 at 02:48:02PM +0100, Elena Petrova wrote: > in_ubsan field of task_struct is only used in lib/ubsan.c, which in its > turn is used only `ifneq ($(CONFIG_UBSAN_TRAP),y)`. > > Removing unnecessary field from a task_struct will help preserve the > ABI between vanilla and CONFIG_U