Re: [PATCH] schedule: use unlikely()

2017-12-08 Thread Greg KH
On Fri, Dec 08, 2017 at 03:30:18PM +0100, Pavel Machek wrote: > On Thu 2017-11-30 08:07:44, Greg KH wrote: > > On Thu, Nov 30, 2017 at 02:04:01AM -0500, Mikulas Patocka wrote: > > > > > > > > > On Tue, 28 Nov 2017, Greg KH wrote: > > > > > > > On Mon, Nov 27, 2017 at 07:05:22PM -0500, Mikulas Pa

Re: [PATCH] schedule: use unlikely()

2017-12-08 Thread Pavel Machek
On Thu 2017-11-30 08:07:44, Greg KH wrote: > On Thu, Nov 30, 2017 at 02:04:01AM -0500, Mikulas Patocka wrote: > > > > > > On Tue, 28 Nov 2017, Greg KH wrote: > > > > > On Mon, Nov 27, 2017 at 07:05:22PM -0500, Mikulas Patocka wrote: > > > > > > > > > > > > On Sat, 25 Nov 2017, Greg KH wrote: >

Re: [PATCH] schedule: use unlikely()

2017-12-08 Thread Pavel Machek
On Tue 2017-11-28 08:22:50, Greg KH wrote: > On Mon, Nov 27, 2017 at 07:05:22PM -0500, Mikulas Patocka wrote: > > > > > > On Sat, 25 Nov 2017, Greg KH wrote: > > > > > On Mon, Nov 13, 2017 at 02:00:45PM -0500, Mikulas Patocka wrote: > > > > A small patch for schedule(), so that the code goes str

Re: [PATCH] schedule: use unlikely()

2017-11-30 Thread Greg KH
On Thu, Nov 30, 2017 at 02:04:01AM -0500, Mikulas Patocka wrote: > > > On Tue, 28 Nov 2017, Greg KH wrote: > > > On Mon, Nov 27, 2017 at 07:05:22PM -0500, Mikulas Patocka wrote: > > > > > > > > > On Sat, 25 Nov 2017, Greg KH wrote: > > > > > > > On Mon, Nov 13, 2017 at 02:00:45PM -0500, Mikul

Re: [PATCH] schedule: use unlikely()

2017-11-29 Thread Mikulas Patocka
On Tue, 28 Nov 2017, Greg KH wrote: > On Mon, Nov 27, 2017 at 07:05:22PM -0500, Mikulas Patocka wrote: > > > > > > On Sat, 25 Nov 2017, Greg KH wrote: > > > > > On Mon, Nov 13, 2017 at 02:00:45PM -0500, Mikulas Patocka wrote: > > > > A small patch for schedule(), so that the code goes straght

Re: [PATCH] schedule: use unlikely()

2017-11-27 Thread Greg KH
On Mon, Nov 27, 2017 at 07:05:22PM -0500, Mikulas Patocka wrote: > > > On Sat, 25 Nov 2017, Greg KH wrote: > > > On Mon, Nov 13, 2017 at 02:00:45PM -0500, Mikulas Patocka wrote: > > > A small patch for schedule(), so that the code goes straght in the common > > > case. > > > > > > Signed-off-by

Re: [PATCH] schedule: use unlikely()

2017-11-27 Thread Mikulas Patocka
On Sat, 25 Nov 2017, Ingo Molnar wrote: > > * Mikulas Patocka wrote: > > > On Fri, 24 Nov 2017, Ingo Molnar wrote: > > > > > > + return unlikely(plug != NULL) && > > > > (!list_empty(&plug->list) || > > > > !list_empty(&plug->mq_list) || > > > >

Re: [PATCH] schedule: use unlikely()

2017-11-27 Thread Mikulas Patocka
On Sat, 25 Nov 2017, Greg KH wrote: > On Mon, Nov 13, 2017 at 02:00:45PM -0500, Mikulas Patocka wrote: > > A small patch for schedule(), so that the code goes straght in the common > > case. > > > > Signed-off-by: Mikulas Patocka > > Was this a measurable difference? If so, great, please pro

Re: [PATCH] schedule: use unlikely()

2017-11-25 Thread Greg KH
On Mon, Nov 13, 2017 at 02:00:45PM -0500, Mikulas Patocka wrote: > A small patch for schedule(), so that the code goes straght in the common > case. > > Signed-off-by: Mikulas Patocka Was this a measurable difference? If so, great, please provide the numbers and how you tested in the changelog.

Re: [PATCH] schedule: use unlikely()

2017-11-25 Thread Ingo Molnar
* Mikulas Patocka wrote: > > > On Fri, 24 Nov 2017, Ingo Molnar wrote: > > > * Mikulas Patocka wrote: > > > > > A small patch for schedule(), so that the code goes straght in the common > > > case. > > > > > > Signed-off-by: Mikulas Patocka > > > > > > --- > > > include/linux/blkdev.h |

Re: [PATCH] schedule: use unlikely()

2017-11-24 Thread Mikulas Patocka
On Fri, 24 Nov 2017, Ingo Molnar wrote: > * Mikulas Patocka wrote: > > > A small patch for schedule(), so that the code goes straght in the common > > case. > > > > Signed-off-by: Mikulas Patocka > > > > --- > > include/linux/blkdev.h |2 +- > > kernel/sched/core.c|2 +- > > 2

Re: [PATCH] schedule: use unlikely()

2017-11-23 Thread Ingo Molnar
* Mikulas Patocka wrote: > A small patch for schedule(), so that the code goes straght in the common > case. > > Signed-off-by: Mikulas Patocka > > --- > include/linux/blkdev.h |2 +- > kernel/sched/core.c|2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > Index: linux

[PATCH] schedule: use unlikely()

2017-11-13 Thread Mikulas Patocka
A small patch for schedule(), so that the code goes straght in the common case. Signed-off-by: Mikulas Patocka --- include/linux/blkdev.h |2 +- kernel/sched/core.c|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6/include/linux/blkdev.h ==