Re: [PATCH] scripts/checkkconfig.py: find unused Kconfig parameters

2013-10-29 Thread Michael Opdenacker
Hi Yann, Thank you for your review! On 10/29/2013 07:06 PM, Yann E. MORIN wrote: > I guess all these grep spawning are what makes it slow. > > I wonder if it would not be possible to invert the loop (in pseudo > Python code): > > for f in all_interesting_files: > read f in memory >

Re: [PATCH] scripts/checkkconfig.py: find unused Kconfig parameters

2013-10-29 Thread Michael Opdenacker
Hi Michal, Thank you very much for your reviews! On 10/25/2013 03:45 PM, Michal Marek wrote: > You can process Kconfig files and source files separately. And you can > speed up the script a lot, if you simply record all CONFIG_* strings > found in the sources, and then compare this to the set of

Re: [PATCH] scripts/checkkconfig.py: find unused Kconfig parameters

2013-10-29 Thread Yann E. MORIN
Michael, All, On 2013-10-24 07:23 +0200, Michael Opdenacker spake thusly: > This is the first version of a script to look for > Kconfig parameters which are still defined but no longer > used in the kernel source code. > > The script may be extended in the future to perform > more checks. This ex

Re: [PATCH] scripts/checkkconfig.py: find unused Kconfig parameters

2013-10-25 Thread Michal Marek
On 25.10.2013 15:38, Michael Opdenacker wrote: > Hi Joe, > > Thank you very much for your review! > > On 10/24/2013 09:30 AM, Joe Perches wrote: >> On Thu, 2013-10-24 at 07:23 +0200, Michael Opdenacker wrote: >> >>> +def count_param(param): >>> + >>> +global source_file, bad_params_in_file >>

Re: [PATCH] scripts/checkkconfig.py: find unused Kconfig parameters

2013-10-25 Thread Michael Opdenacker
Hi Joe, Thank you very much for your review! On 10/24/2013 09:30 AM, Joe Perches wrote: > On Thu, 2013-10-24 at 07:23 +0200, Michael Opdenacker wrote: > >> +def count_param(param): >> + >> +global source_file, bad_params_in_file >> + >> +if os.path.isdir('.git'): >> + # Use git grep

Re: [PATCH] scripts/checkkconfig.py: find unused Kconfig parameters

2013-10-24 Thread Michal Marek
On 24.10.2013 07:23, Michael Opdenacker wrote: > + count = subprocess.check_output('git grep ' + param + '| grep -v > defconfig | wc -l', shell=True) Python 2.6 does not have subprocess.check_output: $ ./scripts/checkkconfig.py INFO: processing Kconfig files... INFO: checking kconfig param

Re: [PATCH] scripts/checkkconfig.py: find unused Kconfig parameters

2013-10-24 Thread Joe Perches
On Thu, 2013-10-24 at 07:23 +0200, Michael Opdenacker wrote: > This is the first version of a script to look for > Kconfig parameters which are still defined but no longer > used in the kernel source code. [] > diff --git a/scripts/checkkconfig.py b/scripts/checkkconfig.py [] > +def count_param(par

[PATCH] scripts/checkkconfig.py: find unused Kconfig parameters

2013-10-23 Thread Michael Opdenacker
This is the first version of a script to look for Kconfig parameters which are still defined but no longer used in the kernel source code. The script may be extended in the future to perform more checks. This explains why a rather generic name was chosen. Several issues have already been reported