Re: [PATCH] scripts/gdb: fix lx-dmesg when CONFIG_PRINTK_CALLER is set

2019-10-10 Thread Leonard Crestez
On 10.10.2019 18:14, Jan Kiszka wrote: > On 25.09.19 17:03, Joel Colledge wrote: >> When CONFIG_PRINTK_CALLER is set, struct printk_log contains an >> additional member caller_id. As a result, the offset of the log text is >> different. >> >> This fixes the following error: >> >>(gdb) lx-dmesg

Re: [PATCH] scripts/gdb: fix lx-dmesg when CONFIG_PRINTK_CALLER is set

2019-10-10 Thread Jan Kiszka
On 25.09.19 17:03, Joel Colledge wrote: > When CONFIG_PRINTK_CALLER is set, struct printk_log contains an > additional member caller_id. As a result, the offset of the log text is > different. > > This fixes the following error: > > (gdb) lx-dmesg > Python Exception embedded null character:

Re: [PATCH] scripts/gdb: fix lx-dmesg when CONFIG_PRINTK_CALLER is set

2019-10-10 Thread Joel Colledge
Hi Jan and Kieran, maintainers of scripts/gdb/, CC: Leonard, most recent contributor to scripts/gdb/linux/dmesg.py Could someone look at this fix please? Is there anything I should improve in the code or the format of the contribution? Thanks.

[PATCH] scripts/gdb: fix lx-dmesg when CONFIG_PRINTK_CALLER is set

2019-09-25 Thread Joel Colledge
When CONFIG_PRINTK_CALLER is set, struct printk_log contains an additional member caller_id. As a result, the offset of the log text is different. This fixes the following error: (gdb) lx-dmesg Python Exception embedded null character: Error occurred in Python command: embedded null