Re: [PATCH] scripts/setlocalversion: make git describe output more reliable

2020-09-16 Thread Masahiro Yamada
On Thu, Sep 17, 2020 at 4:31 AM Rasmus Villemoes wrote: > > On 16/09/2020 20.01, Masahiro Yamada wrote: > > On Thu, Sep 17, 2020 at 12:23 AM Rasmus Villemoes > > wrote: > >> > >> On 16/09/2020 16.28, Masahiro Yamada wrote: > >>> On Fri, Sep 11, 2020 at 5:28 PM Rasmus Villemoes > >>> wrote: >

Re: [PATCH] scripts/setlocalversion: make git describe output more reliable

2020-09-16 Thread Rasmus Villemoes
On 16/09/2020 16.28, Masahiro Yamada wrote: > On Fri, Sep 11, 2020 at 5:28 PM Rasmus Villemoes > wrote: >> >> On 10/09/2020 21.05, Brian Norris wrote: >>> On Thu, Sep 10, 2020 at 7:35 AM Masahiro Yamada >>> wrote: On Thu, Sep 10, 2020 at 8:57 PM Rasmus Villemoes wrote: > So in

Re: [PATCH] scripts/setlocalversion: make git describe output more reliable

2020-09-16 Thread Rasmus Villemoes
On 16/09/2020 20.01, Masahiro Yamada wrote: > On Thu, Sep 17, 2020 at 12:23 AM Rasmus Villemoes > wrote: >> >> On 16/09/2020 16.28, Masahiro Yamada wrote: >>> On Fri, Sep 11, 2020 at 5:28 PM Rasmus Villemoes >>> wrote: >>> Why do we care about the uniqueness of the abbreviated >>> hash in

Re: [PATCH] scripts/setlocalversion: make git describe output more reliable

2020-09-16 Thread Masahiro Yamada
On Thu, Sep 17, 2020 at 12:23 AM Rasmus Villemoes wrote: > > On 16/09/2020 16.28, Masahiro Yamada wrote: > > On Fri, Sep 11, 2020 at 5:28 PM Rasmus Villemoes > > wrote: > >> > >> On 10/09/2020 21.05, Brian Norris wrote: > >>> On Thu, Sep 10, 2020 at 7:35 AM Masahiro Yamada > >>> wrote: >

Re: [PATCH] scripts/setlocalversion: make git describe output more reliable

2020-09-16 Thread Masahiro Yamada
On Fri, Sep 11, 2020 at 5:28 PM Rasmus Villemoes wrote: > > On 10/09/2020 21.05, Brian Norris wrote: > > On Thu, Sep 10, 2020 at 7:35 AM Masahiro Yamada > > wrote: > >> On Thu, Sep 10, 2020 at 8:57 PM Rasmus Villemoes > >> wrote: > >>> So in order to avoid `uname -a` output relying on such

Re: [PATCH] scripts/setlocalversion: make git describe output more reliable

2020-09-16 Thread Rasmus Villemoes
On 10/09/2020 16.34, Masahiro Yamada wrote: > On Thu, Sep 10, 2020 at 8:57 PM Rasmus Villemoes > wrote: >> ... >> >> So in order to avoid `uname -a` output relying on such random details >> of the build environment which are rather hard to ensure are >> consistent between developers and

Re: [PATCH] scripts/setlocalversion: make git describe output more reliable

2020-09-11 Thread Rasmus Villemoes
On 10/09/2020 21.05, Brian Norris wrote: > On Thu, Sep 10, 2020 at 7:35 AM Masahiro Yamada wrote: >> On Thu, Sep 10, 2020 at 8:57 PM Rasmus Villemoes >> wrote: >>> So in order to avoid `uname -a` output relying on such random details >>> of the build environment which are rather hard to ensure

Re: [PATCH] scripts/setlocalversion: make git describe output more reliable

2020-09-10 Thread Bhaskar Chowdhury
On 23:34 Thu 10 Sep 2020, Masahiro Yamada wrote: On Thu, Sep 10, 2020 at 8:57 PM Rasmus Villemoes wrote: When building for an embedded target using Yocto, we're sometimes observing that the version string that gets built into vmlinux (and thus what uname -a reports) differs from the path

[PATCH] scripts/setlocalversion: make git describe output more reliable

2020-09-10 Thread Rasmus Villemoes
When building for an embedded target using Yocto, we're sometimes observing that the version string that gets built into vmlinux (and thus what uname -a reports) differs from the path under /lib/modules/ where modules get installed in the rootfs, but only in the length of the -gabc123def suffix.

Re: [PATCH] scripts/setlocalversion: make git describe output more reliable

2020-09-10 Thread Masahiro Yamada
On Thu, Sep 10, 2020 at 8:57 PM Rasmus Villemoes wrote: > > When building for an embedded target using Yocto, we're sometimes > observing that the version string that gets built into vmlinux (and > thus what uname -a reports) differs from the path under /lib/modules/ > where modules get installed

Re: [PATCH] scripts/setlocalversion: make git describe output more reliable

2020-09-10 Thread Brian Norris
On Thu, Sep 10, 2020 at 7:35 AM Masahiro Yamada wrote: > On Thu, Sep 10, 2020 at 8:57 PM Rasmus Villemoes > wrote: > > So in order to avoid `uname -a` output relying on such random details > > of the build environment which are rather hard to ensure are > > consistent between developers and

Re: [PATCH] scripts/setlocalversion: make git describe output more reliable

2020-09-10 Thread Guenter Roeck
On 9/10/20 4:26 AM, Rasmus Villemoes wrote: > When building for an embedded target using Yocto, we're sometimes > observing that the version string that gets built into vmlinux (and > thus what uname -a reports) differs from the path under /lib/modules/ > where modules get installed in the rootfs,