RE: spdxcheck: python git module considered harmful (was RE: [PATCH] scripts/spdxcheck: Limit the scope of git.Repo)

2025-04-09 Thread Thomas Gleixner
Tim! On Wed, Apr 09 2025 at 17:44, Tim Bird wrote: >> From: Thomas Gleixner >> On Tue, Apr 08 2025 at 17:34, Tim Bird wrote: >> And yes, it ignores not yet tracked files, but if you want to check >> them, then it's easy enough to commit them temporarily or provide a >> dedicated file target to th

RE: spdxcheck: python git module considered harmful (was RE: [PATCH] scripts/spdxcheck: Limit the scope of git.Repo)

2025-04-09 Thread Bird, Tim
> -Original Message- > From: Thomas Gleixner > On Tue, Apr 08 2025 at 17:34, Tim Bird wrote: > >> -Original Message- > > For what it's worth, I've always been a bit skeptical of the use of the > > python git module > > in spdxcheck.py. Its use makes it impossible to use spdxcheck

Re: spdxcheck: python git module considered harmful (was RE: [PATCH] scripts/spdxcheck: Limit the scope of git.Repo)

2025-04-08 Thread Thomas Gleixner
On Tue, Apr 08 2025 at 17:34, Tim Bird wrote: >> -Original Message- > For what it's worth, I've always been a bit skeptical of the use of the > python git module > in spdxcheck.py. Its use makes it impossible to use spdxcheck on a kernel > source tree > from a tarball (ie, on source not

Re: spdxcheck: python git module considered harmful (was RE: [PATCH] scripts/spdxcheck: Limit the scope of git.Repo)

2025-04-08 Thread Ricardo Ribalda
Hi Tim On Tue, 8 Apr 2025 at 20:12, Greg Kroah-Hartman wrote: > > Let me know if anyone objects to me working up a refactoring of spdxcheck.py > > eliminating the use of the python 'git' module, and submitting it for > > review. > > No objection from me! SGTM. Depending on how much time you ne

spdxcheck: python git module considered harmful (was RE: [PATCH] scripts/spdxcheck: Limit the scope of git.Repo)

2025-04-08 Thread Bird, Tim
> -Original Message- > From: Gon Solo > It's a known problem: > https://github.com/gitpython-developers/GitPython/issues/2003 > https://github.com/python/cpython/issues/118761#issuecomment-2661504264 > For what it's worth, I've always been a bit skeptical of the use of the python git mo

Re: spdxcheck: python git module considered harmful (was RE: [PATCH] scripts/spdxcheck: Limit the scope of git.Repo)

2025-04-08 Thread Greg Kroah-Hartman
On Tue, Apr 08, 2025 at 05:34:20PM +, Bird, Tim wrote: > > -Original Message- > > From: Gon Solo > > It's a known problem: > > https://github.com/gitpython-developers/GitPython/issues/2003 > > https://github.com/python/cpython/issues/118761#issuecomment-2661504264 > > > > For what it

Re: [PATCH] scripts/spdxcheck: Limit the scope of git.Repo

2025-04-08 Thread Gon Solo
It's a known problem: https://github.com/gitpython-developers/GitPython/issues/2003 https://github.com/python/cpython/issues/118761#issuecomment-2661504264

Re: [PATCH] scripts/spdxcheck: Limit the scope of git.Repo

2025-04-08 Thread Gon Solo
> > checkpatch suddenly broke for me with the same error as shown here and the > > patch fixed it. > > > > Tested-by: Duje Mihanović Turns out, it was not enough; the variable is used later. How about the following patch? >From 763f25c8ca2e29f343bfd109a17501de71b38d43 Mon Sep 17 00:00:00 2001

Re: [PATCH] scripts/spdxcheck: Limit the scope of git.Repo

2025-04-08 Thread Gon Solo
> checkpatch suddenly broke for me with the same error as shown here and the > patch fixed it. > > Tested-by: Duje Mihanović Same for me. Tested-by: Andreas Wendleder

Re: [PATCH] scripts/spdxcheck: Limit the scope of git.Repo

2025-04-07 Thread Duje Mihanović
On Tuesday, 25 February 2025 14:10:41 Central European Summer Time Ricardo Ribalda wrote: > If the git.Repo object's scope extends to the Python interpreter's > shutdown phase, its destructor may fail due to the interpreter's state. > > Exception ignored in: > Traceback (most recent call last):

Re: [PATCH] scripts/spdxcheck: Limit the scope of git.Repo

2025-04-04 Thread Greg Kroah-Hartman
On Fri, Apr 04, 2025 at 08:29:21AM +0200, Ricardo Ribalda wrote: > On Fri, 4 Apr 2025 at 08:22, Greg Kroah-Hartman > wrote: > > > > On Thu, Apr 03, 2025 at 11:34:14PM +0200, Ricardo Ribalda wrote: > > > Friendly ping > > > > Empty pings provide no context at all :( > > Do you mean that I'd rather

Re: [PATCH] scripts/spdxcheck: Limit the scope of git.Repo

2025-04-03 Thread Ricardo Ribalda
On Fri, 4 Apr 2025 at 08:22, Greg Kroah-Hartman wrote: > > On Thu, Apr 03, 2025 at 11:34:14PM +0200, Ricardo Ribalda wrote: > > Friendly ping > > Empty pings provide no context at all :( Do you mean that I'd rather left the whole patch as context, or that I should provide a reason for the ping?

Re: [PATCH] scripts/spdxcheck: Limit the scope of git.Repo

2025-04-03 Thread Greg Kroah-Hartman
On Thu, Apr 03, 2025 at 11:34:14PM +0200, Ricardo Ribalda wrote: > Friendly ping Empty pings provide no context at all :(

Re: [PATCH] scripts/spdxcheck: Limit the scope of git.Repo

2025-04-03 Thread Ricardo Ribalda
Friendly ping

[PATCH] scripts/spdxcheck: Limit the scope of git.Repo

2025-02-25 Thread Ricardo Ribalda
If the git.Repo object's scope extends to the Python interpreter's shutdown phase, its destructor may fail due to the interpreter's state. Exception ignored in: Traceback (most recent call last): File "/usr/lib/python3/dist-packages/git/cmd.py", line 565, in __del__ File "/usr/lib/python3/dis