On Wed, Dec 19, 2012 at 09:43:42AM -0800, Joe Perches wrote:
> When I use this file
> $ cat .git/hooks/pre-commit
> exec git diff --cached HEAD -- | ./scripts/checkpatch.pl --strict -
> $
>
> it works fine.
> ^
> Here's the latest checkpatch diff without that
> concatenation warning for you to tr
On Wed, 2012-12-19 at 16:07 +0100, Borislav Petkov wrote:
> On Tue, Dec 18, 2012 at 01:33:19PM -0800, Joe Perches wrote:
> > On Tue, 2012-12-18 at 21:47 +0100, Borislav Petkov wrote:
> > > Oh well, enough games for today.
> >
> > Maybe try this tomorrow?
>
> $ git diff --cached HEAD -- | ./script
On Tue, Dec 18, 2012 at 01:33:19PM -0800, Joe Perches wrote:
> On Tue, 2012-12-18 at 21:47 +0100, Borislav Petkov wrote:
> > Oh well, enough games for today.
>
> Maybe try this tomorrow?
$ git diff --cached HEAD -- | ./scripts/checkpatch.pl --strict -
Use of uninitialized value $herecurr in conca
On Tue, 2012-12-18 at 21:47 +0100, Borislav Petkov wrote:
> Oh well, enough games for today.
Maybe try this tomorrow?
scripts/checkpatch.pl | 40 ++--
1 files changed, 38 insertions(+), 2 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.p
On Tue, Dec 18, 2012 at 12:36:37PM -0800, Joe Perches wrote:
> You renamed README which is one of the filenames used
> when checkpatch verifies the top-level dir kernel tree.
>
> Don't do that, README is a required filename.
$ git mv scripts/checkpatch{,-2}.pl
$ git diff --cached HEAD -- | ./scri
On Tue, 2012-12-18 at 21:31 +0100, Borislav Petkov wrote:
> On Tue, Dec 18, 2012 at 11:34:41AM -0800, Joe Perches wrote:
> > If no patch is attached, you should get
> >
> > ERROR: Does not appear to be a unified-diff format patch
>
> Well, it needs to handle the case where a patch simply and only
On Tue, Dec 18, 2012 at 11:34:41AM -0800, Joe Perches wrote:
> If no patch is attached, you should get
>
> ERROR: Does not appear to be a unified-diff format patch
Well, it needs to handle the case where a patch simply and only renames
a file.
Then, even if a patch follows:
diff --git a/README b
On Tue, 2012-12-18 at 19:28 +0100, Borislav Petkov wrote:
> On Mon, Dec 17, 2012 at 11:09:43AM -0800, Joe Perches wrote:
> > This needs a new test here to avoid chirping
> > on files that aren't added, deleted or renamed.
> >
> > next if ($realfile eq $modifiedfile);
>
> Hmm, I don't
On Mon, Dec 17, 2012 at 11:09:43AM -0800, Joe Perches wrote:
> This needs a new test here to avoid chirping
> on files that aren't added, deleted or renamed.
>
> next if ($realfile eq $modifiedfile);
Hmm, I don't think that catches file renames when using the normal 'git
diff' outpu
Em 17-12-2012 15:00, Borislav Petkov escreveu:
On Mon, Dec 17, 2012 at 07:35:44AM -0800, Joe Perches wrote:
Perhaps Cesar can use his script as a starting point to find those
pattern invalidating commits or maybe add the capability (or a
--strict check) to checkpatch.
Or that, I don't have a s
On Mon, 2012-12-17 at 10:56 -0800, Joe Perches wrote:
> On Mon, 2012-12-17 at 18:00 +0100, Borislav Petkov wrote:
> > On Mon, Dec 17, 2012 at 07:35:44AM -0800, Joe Perches wrote:
> > > Perhaps Cesar can use his script as a starting point to find those
> > > pattern invalidating commits or maybe add
On Mon, 2012-12-17 at 18:00 +0100, Borislav Petkov wrote:
> On Mon, Dec 17, 2012 at 07:35:44AM -0800, Joe Perches wrote:
> > Perhaps Cesar can use his script as a starting point to find those
> > pattern invalidating commits or maybe add the capability (or a
> > --strict check) to checkpatch.
>
>
On Mon, Dec 17, 2012 at 07:35:44AM -0800, Joe Perches wrote:
> Perhaps Cesar can use his script as a starting point to find those
> pattern invalidating commits or maybe add the capability (or a
> --strict check) to checkpatch.
Or that, I don't have a strict preference.
So, yeah, I can see how ch
On Mon, 2012-12-17 at 11:27 +0100, Borislav Petkov wrote:
> On Mon, Dec 17, 2012 at 11:14:24AM +0100, Michal Marek wrote:
> > On 14.12.2012 23:19, Cesar Eduardo Barros wrote:
> > > This small script checks the file patterns in the MAINTAINERS file.
> > >
> > > For every file pattern, it checks if
On Mon, Dec 17, 2012 at 11:14:24AM +0100, Michal Marek wrote:
> On 14.12.2012 23:19, Cesar Eduardo Barros wrote:
> > This small script checks the file patterns in the MAINTAINERS file.
> >
> > For every file pattern, it checks if the pattern matches any file or
> > directory in the kernel tree, pr
On 14.12.2012 23:19, Cesar Eduardo Barros wrote:
> This small script checks the file patterns in the MAINTAINERS file.
>
> For every file pattern, it checks if the pattern matches any file or
> directory in the kernel tree, printing the patterns which do not have a
> match.
Can't this be added as
This small script checks the file patterns in the MAINTAINERS file.
For every file pattern, it checks if the pattern matches any file or
directory in the kernel tree, printing the patterns which do not have a
match.
It also checks for any file pattern pointing to any of the include
directories wh
17 matches
Mail list logo
