On Fri, Sep 14, 2018 at 7:12 PM, Miguel Ojeda
wrote:
> Hi Harshit,
Another two nitpicks:
* Since this is the second version of the patch, write "[PATCH v2]"
in the title instead; that way people know you have sent an earlier
version. On top of that, you should explain the differences between
On Fri, Sep 14, 2018 at 7:12 PM, Miguel Ojeda
wrote:
> Hi Harshit,
Another two nitpicks:
* Since this is the second version of the patch, write "[PATCH v2]"
in the title instead; that way people know you have sent an earlier
version. On top of that, you should explain the differences between
Hi Harshit,
On Fri, Sep 14, 2018 at 12:44 PM, Harshit Jain
wrote:
> From: Harshit Jain
>
> * This commit resolves the following warning when the mainline kernel is
> build with the android environment.
Typo: built
>
> -> warning :->
>
Hi Harshit,
On Fri, Sep 14, 2018 at 12:44 PM, Harshit Jain
wrote:
> From: Harshit Jain
>
> * This commit resolves the following warning when the mainline kernel is
> build with the android environment.
Typo: built
>
> -> warning :->
>
From: Harshit Jain
* This commit resolves the following warning when the mainline kernel is build
with the android environment.
-> warning :->
https://gist.github.com/dev-harsh1998/757427b16a58f5498db3d87212a9651b
* This warning is persistant in all the currently maintained android kernel
From: Harshit Jain
* This commit resolves the following warning when the mainline kernel is build
with the android environment.
-> warning :->
https://gist.github.com/dev-harsh1998/757427b16a58f5498db3d87212a9651b
* This warning is persistant in all the currently maintained android kernel
Harshit Jain wrote:
> Hey! tony thanks for reviewing, pardon me i wasn't able to get your context
> can you please elaborate a little what you are trying to say?
There's a big block comment above the state machine code which tries to
explain what the blazes is going on. The comment includes an
Harshit Jain wrote:
> Hey! tony thanks for reviewing, pardon me i wasn't able to get your context
> can you please elaborate a little what you are trying to say?
There's a big block comment above the state machine code which tries to
explain what the blazes is going on. The comment includes an
Harshit Jain wrote:
> /* modify this line */
> -static void Mpass (void) { strncpy(keyword, "if ", 4); Pelif(); }
> +static void Mpass (void) { memcpy(keyword, "if ", 4); Pelif(); }
Yes, this is a good improvement, but you also need to update the comment
to match the code.
Tony.
--
Harshit Jain wrote:
> /* modify this line */
> -static void Mpass (void) { strncpy(keyword, "if ", 4); Pelif(); }
> +static void Mpass (void) { memcpy(keyword, "if ", 4); Pelif(); }
Yes, this is a good improvement, but you also need to update the comment
to match the code.
Tony.
--
While compiling the mainline kernel in android env with latest gcc 8 the
compiler threw this warning Thanks to the advantage of improved static analysis
in newer gcc we are now able to
see this warning this patch resolves the detected compiler warnings.
Signed-off-by: Harshit Jain
---
While compiling the mainline kernel in android env with latest gcc 8 the
compiler threw this warning Thanks to the advantage of improved static analysis
in newer gcc we are now able to
see this warning this patch resolves the detected compiler warnings.
Signed-off-by: Harshit Jain
---
12 matches
Mail list logo
