Re: [PATCH] scsi/atari_scsi: Fix race condition between .queuecommand and EH

2020-11-30 Thread Martin K. Petersen
On Fri, 20 Nov 2020 15:39:56 +1100, Finn Thain wrote: > It is possible that bus_reset_cleanup() or .eh_abort_handler could > be invoked during NCR5380_queuecommand(). If that takes place before > the new command is enqueued and after the ST-DMA "lock" has been > acquired, the ST-DMA "lock" will be

Re: [PATCH] scsi/atari_scsi: Fix race condition between .queuecommand and EH

2020-11-23 Thread Martin K. Petersen
Finn, > It is possible that bus_reset_cleanup() or .eh_abort_handler could be > invoked during NCR5380_queuecommand(). If that takes place before the > new command is enqueued and after the ST-DMA "lock" has been acquired, > the ST-DMA "lock" will be released again. This will result in a lost >

Re: [PATCH] scsi/atari_scsi: Fix race condition between .queuecommand and EH

2020-11-19 Thread Michael Schmitz
Hi Finn, thanks for your patch! Tested on Atari Falcon (with falconide, and pata_falcon modules). Reviewed-by: Michael Schmitz Tested-by: Michael Schmitz Am 20.11.2020 um 17:39 schrieb Finn Thain: It is possible that bus_reset_cleanup() or .eh_abort_handler could be invoked during NCR5380_q

[PATCH] scsi/atari_scsi: Fix race condition between .queuecommand and EH

2020-11-19 Thread Finn Thain
It is possible that bus_reset_cleanup() or .eh_abort_handler could be invoked during NCR5380_queuecommand(). If that takes place before the new command is enqueued and after the ST-DMA "lock" has been acquired, the ST-DMA "lock" will be released again. This will result in a lost DMA interrupt and a