Re: [PATCH] scsi: Use 'blist_flags_t' for scsi_devinfo flags

2017-11-15 Thread Martin K. Petersen
Hi Hannes, > As per recommendation from Linus we should be using a distinct > type for blacklist flags. > -#define BLIST_MAX_1024 ((__force __u32 __bitwise)(1 << 30)) > +#define BLIST_MAX_1024 ((__force blist_flags_t)(1 << 30)) You are missing: /* Use UNMAP limit for

Re: [PATCH] scsi: Use 'blist_flags_t' for scsi_devinfo flags

2017-11-15 Thread Bart Van Assche
On Wed, 2017-11-15 at 12:07 +0100, Hannes Reinecke wrote: > As per recommendation from Linus we should be using a distinct > type for blacklist flags. Hello Hannes, Have you noticed that this patch is a subset of the patch series I posted yesterday (https://marc.info/?l=linux-scsi&m=1510713331132

[PATCH] scsi: Use 'blist_flags_t' for scsi_devinfo flags

2017-11-15 Thread Hannes Reinecke
As per recommendation from Linus we should be using a distinct type for blacklist flags. Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_devinfo.c | 18 - drivers/scsi/scsi_priv.h| 15 +++--- drivers/scsi/scsi_scan.c| 2 +- include/scsi/scsi_device.h | 4 +