Re: [PATCH] scsi: aacraid: Fix missing break in switch statement

2019-02-27 Thread Gustavo A. R. Silva
On 2/27/19 8:33 AM, Martin K. Petersen wrote: > > Gustavo, > >> Add missing break statement and fix identation issue. > > So much bad indentation in this driver. Tried various tab widths and it > is still all over the place. > > Anyway. After staring at the firmware header I have convinced

Re: [PATCH] scsi: aacraid: Fix missing break in switch statement

2019-02-27 Thread Martin K. Petersen
Gustavo, > Add missing break statement and fix identation issue. So much bad indentation in this driver. Tried various tab widths and it is still all over the place. Anyway. After staring at the firmware header I have convinced myself that your fix is correct. Applied to 5.1/scsi-queue. --

[PATCH] scsi: aacraid: Fix missing break in switch statement

2019-02-15 Thread Gustavo A. R. Silva
Add missing break statement and fix identation issue. This bug was found thanks to the ongoing efforts to enable -Wimplicit-fallthrough. Fixes: 9cb62fa24e0d ("aacraid: Log firmware AIF messages") Cc: sta...@vger.kernel.org Signed-off-by: Gustavo A. R. Silva --- drivers/scsi/aacraid/commsup.c |