Re: [PATCH] scsi: arcmsr: Remove the superfluous break

2020-09-18 Thread Jing Xiangfeng
On 2020/9/18 22:56, Gustavo A. R. Silva wrote: On Fri, Sep 18, 2020 at 05:32:30PM +0800, Jing Xiangfeng wrote: Remove the superfluous break, as there is a 'return' before it. Apparently, the change is correct. Please, just add a proper Fixes tag by yourself this time. Thanks for comments

Re: [PATCH] scsi: arcmsr: Remove the superfluous break

2020-09-18 Thread Joe Perches
On Fri, 2020-09-18 at 11:17 -0600, Jens Axboe wrote: > On 9/18/20 11:13 AM, Joe Perches wrote: > > On Fri, 2020-09-18 at 09:56 -0500, Gustavo A. R. Silva wrote: > > > On Fri, Sep 18, 2020 at 05:32:30PM +0800, Jing Xiangfeng wrote: > > > > Remove the superfluous break, as there is a 'return' before

Re: [PATCH] scsi: arcmsr: Remove the superfluous break

2020-09-18 Thread Colin Ian King
On 18/09/2020 19:00, Dan Carpenter wrote: > Smatch just ignores these because they're often done deliberately. > > regards, > dan carpenter > And I ignore fixing them when coverity reports them because life is too short. Colin

Re: [PATCH] scsi: arcmsr: Remove the superfluous break

2020-09-18 Thread Dan Carpenter
Smatch just ignores these because they're often done deliberately. regards, dan carpenter

Re: [PATCH] scsi: arcmsr: Remove the superfluous break

2020-09-18 Thread Jens Axboe
On 9/18/20 11:13 AM, Joe Perches wrote: > On Fri, 2020-09-18 at 09:56 -0500, Gustavo A. R. Silva wrote: >> On Fri, Sep 18, 2020 at 05:32:30PM +0800, Jing Xiangfeng wrote: >>> Remove the superfluous break, as there is a 'return' before it. >>> >> >> Apparently, the change is correct. Please, just ad

Re: [PATCH] scsi: arcmsr: Remove the superfluous break

2020-09-18 Thread Joe Perches
On Fri, 2020-09-18 at 09:56 -0500, Gustavo A. R. Silva wrote: > On Fri, Sep 18, 2020 at 05:32:30PM +0800, Jing Xiangfeng wrote: > > Remove the superfluous break, as there is a 'return' before it. > > > > Apparently, the change is correct. Please, just add a proper Fixes tag by > yourself this tim

Re: [PATCH] scsi: arcmsr: Remove the superfluous break

2020-09-18 Thread Gustavo A. R. Silva
On Fri, Sep 18, 2020 at 05:32:30PM +0800, Jing Xiangfeng wrote: > Remove the superfluous break, as there is a 'return' before it. > Apparently, the change is correct. Please, just add a proper Fixes tag by yourself this time. Thanks -- Gustavo > Signed-off-by: Jing Xiangfeng > --- > drivers/sc

[PATCH] scsi: arcmsr: Remove the superfluous break

2020-09-18 Thread Jing Xiangfeng
Remove the superfluous break, as there is a 'return' before it. Signed-off-by: Jing Xiangfeng --- drivers/scsi/arcmsr/arcmsr_hba.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index ec895d0319f0..74add6d247d5 100644 ---