Re: [PATCH] scsi: be2iscsi: Fix a theoretical leak in beiscsi_create_eqs()

2020-12-03 Thread Dan Carpenter
On Thu, Dec 03, 2020 at 11:10:09AM +0100, Thomas Lamprecht wrote: > > The be_fill_queue() function can only fail when "eq_vaddress" is NULL > > and since it's non-NULL here that means the function call can't fail. > > But imagine if it could, then in that situation we would want to store > > the

Re: [PATCH] scsi: be2iscsi: Fix a theoretical leak in beiscsi_create_eqs()

2020-12-03 Thread Thomas Lamprecht
> The be_fill_queue() function can only fail when "eq_vaddress" is NULL > and since it's non-NULL here that means the function call can't fail. > But imagine if it could, then in that situation we would want to store > the "paddr" so that dma memory can be released. > > Fixes: bfead3b2cb46

Re: [PATCH] scsi: be2iscsi: Fix a theoretical leak in beiscsi_create_eqs()

2020-10-06 Thread Martin K. Petersen
On Mon, 28 Sep 2020 12:13:00 +0300, Dan Carpenter wrote: > The be_fill_queue() function can only fail when "eq_vaddress" is NULL > and since it's non-NULL here that means the function call can't fail. > But imagine if it could, then in that situation we would want to store > the "paddr" so that

[PATCH] scsi: be2iscsi: Fix a theoretical leak in beiscsi_create_eqs()

2020-09-28 Thread Dan Carpenter
The be_fill_queue() function can only fail when "eq_vaddress" is NULL and since it's non-NULL here that means the function call can't fail. But imagine if it could, then in that situation we would want to store the "paddr" so that dma memory can be released. Fixes: bfead3b2cb46 ("[SCSI] be2iscsi: