Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-18 Thread Geyslan Gregório Bem
2013/11/18 Geyslan Gregório Bem : > 2013/11/18 James Bottomley : >> On Mon, 2013-11-18 at 14:18 -0200, Geyslan Gregório Bem wrote: >>> 2013/11/18 James Bottomley : >>> > On Sun, 2013-11-17 at 23:12 -0200, Geyslan Gregório Bem wrote: >>> >> 2013/11/17 James Bottomley : >>> >> > On Sun, 2013-11-17

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-18 Thread Geyslan Gregório Bem
2013/11/18 James Bottomley : > On Mon, 2013-11-18 at 14:18 -0200, Geyslan Gregório Bem wrote: >> 2013/11/18 James Bottomley : >> > On Sun, 2013-11-17 at 23:12 -0200, Geyslan Gregório Bem wrote: >> >> 2013/11/17 James Bottomley : >> >> > On Sun, 2013-11-17 at 19:09 -0200, Geyslan Gregório Bem

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-18 Thread James Bottomley
On Mon, 2013-11-18 at 14:18 -0200, Geyslan Gregório Bem wrote: > 2013/11/18 James Bottomley : > > On Sun, 2013-11-17 at 23:12 -0200, Geyslan Gregório Bem wrote: > >> 2013/11/17 James Bottomley : > >> > On Sun, 2013-11-17 at 19:09 -0200, Geyslan Gregório Bem wrote: > >> >> 2013/11/17 James

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-18 Thread Geyslan Gregório Bem
2013/11/18 James Bottomley : > On Sun, 2013-11-17 at 23:12 -0200, Geyslan Gregório Bem wrote: >> 2013/11/17 James Bottomley : >> > On Sun, 2013-11-17 at 19:09 -0200, Geyslan Gregório Bem wrote: >> >> 2013/11/17 James Bottomley : >> >> > On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote: >>

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-18 Thread James Bottomley
On Sun, 2013-11-17 at 23:12 -0200, Geyslan Gregório Bem wrote: > 2013/11/17 James Bottomley : > > On Sun, 2013-11-17 at 19:09 -0200, Geyslan Gregório Bem wrote: > >> 2013/11/17 James Bottomley : > >> > On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote: > >> >> This patch fix memory leakage

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-18 Thread James Bottomley
On Sun, 2013-11-17 at 23:12 -0200, Geyslan Gregório Bem wrote: 2013/11/17 James Bottomley james.bottom...@hansenpartnership.com: On Sun, 2013-11-17 at 19:09 -0200, Geyslan Gregório Bem wrote: 2013/11/17 James Bottomley james.bottom...@hansenpartnership.com: On Sun, 2013-11-17 at 15:51

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-18 Thread Geyslan Gregório Bem
2013/11/18 James Bottomley james.bottom...@hansenpartnership.com: On Sun, 2013-11-17 at 23:12 -0200, Geyslan Gregório Bem wrote: 2013/11/17 James Bottomley james.bottom...@hansenpartnership.com: On Sun, 2013-11-17 at 19:09 -0200, Geyslan Gregório Bem wrote: 2013/11/17 James Bottomley

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-18 Thread James Bottomley
On Mon, 2013-11-18 at 14:18 -0200, Geyslan Gregório Bem wrote: 2013/11/18 James Bottomley james.bottom...@hansenpartnership.com: On Sun, 2013-11-17 at 23:12 -0200, Geyslan Gregório Bem wrote: 2013/11/17 James Bottomley james.bottom...@hansenpartnership.com: On Sun, 2013-11-17 at 19:09

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-18 Thread Geyslan Gregório Bem
2013/11/18 James Bottomley james.bottom...@hansenpartnership.com: On Mon, 2013-11-18 at 14:18 -0200, Geyslan Gregório Bem wrote: 2013/11/18 James Bottomley james.bottom...@hansenpartnership.com: On Sun, 2013-11-17 at 23:12 -0200, Geyslan Gregório Bem wrote: 2013/11/17 James Bottomley

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-18 Thread Geyslan Gregório Bem
2013/11/18 Geyslan Gregório Bem geys...@gmail.com: 2013/11/18 James Bottomley james.bottom...@hansenpartnership.com: On Mon, 2013-11-18 at 14:18 -0200, Geyslan Gregório Bem wrote: 2013/11/18 James Bottomley james.bottom...@hansenpartnership.com: On Sun, 2013-11-17 at 23:12 -0200, Geyslan

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-17 Thread Geyslan Gregório Bem
2013/11/17 James Bottomley : > On Sun, 2013-11-17 at 19:09 -0200, Geyslan Gregório Bem wrote: >> 2013/11/17 James Bottomley : >> > On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote: >> >> This patch fix memory leakage in cases 'ISCSI_NET_PARAM_VLAN_ID' and >> >>

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-17 Thread James Bottomley
On Sun, 2013-11-17 at 19:09 -0200, Geyslan Gregório Bem wrote: > 2013/11/17 James Bottomley : > > On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote: > >> This patch fix memory leakage in cases 'ISCSI_NET_PARAM_VLAN_ID' and > >> 'ISCSI_NET_PARAM_VLAN_PRIORITY' and refactors code 'going out'

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-17 Thread Geyslan Gregório Bem
2013/11/17 James Bottomley : > On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote: >> This patch fix memory leakage in cases 'ISCSI_NET_PARAM_VLAN_ID' and >> 'ISCSI_NET_PARAM_VLAN_PRIORITY' and refactors code 'going out' when >> necessary. > > You pointlessly renamed a variable, which makes

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-17 Thread James Bottomley
On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote: > This patch fix memory leakage in cases 'ISCSI_NET_PARAM_VLAN_ID' and > 'ISCSI_NET_PARAM_VLAN_PRIORITY' and refactors code 'going out' when > necessary. You pointlessly renamed a variable, which makes the diff hard to read. Please don't do

[PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-17 Thread Geyslan G. Bem
This patch fix memory leakage in cases 'ISCSI_NET_PARAM_VLAN_ID' and 'ISCSI_NET_PARAM_VLAN_PRIORITY' and refactors code 'going out' when necessary. Signed-off-by: Geyslan G. Bem --- drivers/scsi/be2iscsi/be_iscsi.c | 41 +--- 1 file changed, 22 insertions(+),

[PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-17 Thread Geyslan G. Bem
This patch fix memory leakage in cases 'ISCSI_NET_PARAM_VLAN_ID' and 'ISCSI_NET_PARAM_VLAN_PRIORITY' and refactors code 'going out' when necessary. Signed-off-by: Geyslan G. Bem geys...@gmail.com --- drivers/scsi/be2iscsi/be_iscsi.c | 41 +--- 1 file changed,

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-17 Thread James Bottomley
On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote: This patch fix memory leakage in cases 'ISCSI_NET_PARAM_VLAN_ID' and 'ISCSI_NET_PARAM_VLAN_PRIORITY' and refactors code 'going out' when necessary. You pointlessly renamed a variable, which makes the diff hard to read. Please don't do

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-17 Thread Geyslan Gregório Bem
2013/11/17 James Bottomley james.bottom...@hansenpartnership.com: On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote: This patch fix memory leakage in cases 'ISCSI_NET_PARAM_VLAN_ID' and 'ISCSI_NET_PARAM_VLAN_PRIORITY' and refactors code 'going out' when necessary. You pointlessly

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-17 Thread James Bottomley
On Sun, 2013-11-17 at 19:09 -0200, Geyslan Gregório Bem wrote: 2013/11/17 James Bottomley james.bottom...@hansenpartnership.com: On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote: This patch fix memory leakage in cases 'ISCSI_NET_PARAM_VLAN_ID' and 'ISCSI_NET_PARAM_VLAN_PRIORITY' and

Re: [PATCH] scsi: be_iscsi: fix possible memory leak and refactor code

2013-11-17 Thread Geyslan Gregório Bem
2013/11/17 James Bottomley james.bottom...@hansenpartnership.com: On Sun, 2013-11-17 at 19:09 -0200, Geyslan Gregório Bem wrote: 2013/11/17 James Bottomley james.bottom...@hansenpartnership.com: On Sun, 2013-11-17 at 15:51 -0300, Geyslan G. Bem wrote: This patch fix memory leakage in cases